Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-locale version for full language integration on macos #5330

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Dec 17, 2024

Description:

With this the preferred language from the languages list is used as it should on macOS.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.657% (+0.02%) from 59.64%
when pulling f67986a on sdassow:update-go-locale-version
into c6d4727 on fyne-io:develop.

@Jacalz
Copy link
Member

Jacalz commented Dec 17, 2024

Please don't remove the PR checklist. It is meant to be filled out :)

@sdassow
Copy link
Contributor Author

sdassow commented Dec 17, 2024

Ok, added them back. Only removed them because they don't mean much for this PR I think.

@Jacalz
Copy link
Member

Jacalz commented Dec 17, 2024

Sorry to be picky but they are meant to stay. However, you should not fill in the one about adding tests if you haven't added any (but do keep the line with only the box not being checked).

@sdassow
Copy link
Contributor Author

sdassow commented Dec 17, 2024

Right, changed. There are no new tests, but existing tests cover it, which I've used as qualifier ;-).

@sdassow sdassow merged commit 0afa6a9 into fyne-io:develop Dec 19, 2024
12 checks passed
@sdassow sdassow deleted the update-go-locale-version branch December 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants