Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store time function in each cursor animation #5326

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Dec 17, 2024

Description:

This avoids carrying around the baggage of each entry cursor animation having a field for the time value. Lets just define it globally and change it in tests. The compiler should be able to remove the variable in an optimisation pass somewhere.

NOTE: We can likely remove all of these custom time variables when the synctest package lands (Go 1.24 or newer).

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.947% (-0.02%) from 59.964%
when pulling 307be7d on Jacalz:no-time-func-per-cursor
into 7fea2eb on fyne-io:develop.

@Jacalz Jacalz merged commit c6d4727 into fyne-io:develop Dec 17, 2024
12 checks passed
@Jacalz Jacalz deleted the no-time-func-per-cursor branch December 17, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants