Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting title of inner window after creation #4434

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Support setting title of inner window after creation #4434

merged 3 commits into from
Dec 4, 2023

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Dec 1, 2023 •
edited
Loading

Also fixed a sizing bug

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Support setting the title of InnerWindow
2b8bec5 
No since: 2.5 needed as this is a new type so the parent has that info
@andydotxyz
Also don't make it so windows can never shrink
bf7f59c 
That was misguided... I think an artefact of bad MultiWindow code that was in earlier
@andydotxyz
Add setTitle test
3c2ec30
@coveralls
Copy link

coveralls commented Dec 1, 2023 •
edited
Loading

Coverage Status

coverage: 65.097% (+0.001%) from 65.096%
when pulling 3c2ec30 on andydotxyz:feature/innertitle
into 4a18a7f on fyne-io:develop.

@andydotxyz andydotxyz merged commit 261ac0d into fyne-io:develop Dec 4, 2023
10 of 11 checks passed
@andydotxyz andydotxyz deleted the feature/innertitle branch December 4, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz