Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct row header width/height in widget.Table retry of PR #(4421) #4427

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Correct row header width/height in widget.Table retry of PR #(4421) #4427

merged 1 commit into from
Dec 6, 2023

Conversation

Ju-B
Copy link
Contributor

@Ju-B Ju-B commented Nov 28, 2023

Description:

Allows to set width and height of headers using methods: SetColumnWidth and SetRowHeight with index -1
retry of PR #(4421)

Fixes #(4370)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Ju-B
Correct row header width/height in widget.Table
044da8e 
Allows to set width and height of headers using methods: SetColumnWidth and SetRowHeight with index -1
@coveralls
Copy link

Coverage Status

coverage: 65.095% (-0.001%) from 65.096%
when pulling 044da8e on Ju-B:patch-1
into 4a18a7f on fyne-io:develop.

andydotxyz
andydotxyz approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, looks like a good improvement

@andydotxyz andydotxyz merged commit 450d875 into fyne-io:develop Dec 6, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ju-B @coveralls @andydotxyz