fix: get_by_query() and get_all() for empty response

[ashwin1111]

https://app.clickup.com/t/86cwqkbt6

Summary by CodeRabbit

• New Features

  • Enhanced API response handling for improved robustness and error prevention in data retrieval methods.

• Chores

  • Updated the package version from 1.23.1 to 1.23.2.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily involve modifications to the ApiBase class within the sageintacctsdk/apis/api_base.py file. Key updates include improved handling of API responses in the get_all, get_all_generator, and get_by_query methods, ensuring that the presence of self.__dimension is verified before data extraction. Additionally, the version number in the setup.py file has been updated from 1.23.1 to 1.23.2.

Changes

File	Change Summary
sageintacctsdk/apis/api_base.py	Updated response handling in get_all, get_all_generator, and get_by_query methods to check for self.__dimension before accessing data.
setup.py	Updated package version from 1.23.1 to 1.23.2.

Possibly related PRs

• fix: Count call without filters #94: The changes in this PR also modify the get_all, get_all_generator, and get_by_query methods in the ApiBase class, enhancing their functionality and error handling, which is directly related to the response handling improvements made in the main PR.

Suggested reviewers

• Hrishabh17

Poem

In the code where rabbits play,
We check for keys in a careful way.
With each response, we hop and cheer,
No more errors, let’s spread good cheer!
Version updated, we’re on our way,
To a smoother, brighter coding day! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

PR description must contain a link to a ClickUp (case-insensitive)