Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method for fetching inactive records #24

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Conversation

Hrishabh17
Copy link
Contributor

No description provided.

@Hrishabh17 Hrishabh17 requested a review from ashwin1111 March 5, 2024 09:15
@Hrishabh17 Hrishabh17 changed the title Add get generator Added method for fetching inactive records Mar 5, 2024
Copy link
Contributor

@ashwin1111 ashwin1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump version as well

@@ -24,3 +24,18 @@ def get_all_generator(self):
Generator with dicts in Accounts schema.
"""
return self._query_get_all_generator('Account', Accounts.GET_ACCOUNTS)

def get_inactive(self, last_updated_time):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it optional, everywhere

@Hrishabh17 Hrishabh17 requested a review from ashwin1111 March 5, 2024 09:25
@Hrishabh17 Hrishabh17 merged commit 602f644 into master Mar 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants