Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for multi DB producer #17

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Conversation

ashwin1111
Copy link
Contributor

No description provided.

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
common
   compression.py5180%9
   log.py90100% 
   utils.py302033%17–60
common/qconnector
   rabbitmq_connector.py451371%23–24, 37–49, 52–65
consumer
   event_consumer.py340100% 
pgoutput_parser
   base.py610100% 
   delete.py140100% 
   insert.py150100% 
   relation.py270100% 
   update.py190100% 
producer
   event_producer.py1482682%118–122, 215–217, 223–224, 229–235, 238–241, 244–245, 248–252
TOTAL4076085% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 0.199s ⏱️

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
common
   compression.py5180%9
   log.py90100% 
   utils.py302033%17–60
common/qconnector
   rabbitmq_connector.py451371%23–24, 37–49, 52–65
consumer
   event_consumer.py340100% 
pgoutput_parser
   base.py610100% 
   delete.py140100% 
   insert.py150100% 
   relation.py270100% 
   update.py190100% 
producer
   event_producer.py1482682%118–122, 215–217, 223–224, 229–235, 238–241, 244–245, 248–252
TOTAL4076085% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 0.204s ⏱️



@click.command()
@click.option('--db_configs', default=lambda: os.environ.get('DB_CONFIGS', None), required=True, help='DB Configs')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For multiple dbs this looks a little dirty
I would prefer that we get all this config from a yaml file.

Eg. what if for different producer I want different settings altogether

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay for now, but please fix this later

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
common
   compression.py5180%9
   log.py90100% 
   utils.py30197%35
common/qconnector
   rabbitmq_connector.py451371%23–24, 37–49, 52–65
consumer
   event_consumer.py340100% 
pgoutput_parser
   base.py610100% 
   delete.py140100% 
   insert.py150100% 
   relation.py270100% 
   update.py190100% 
producer
   event_producer.py1482682%118–122, 215–217, 223–224, 229–235, 238–241, 244–245, 248–252
TOTAL4074190% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 0.237s ⏱️

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
common
   compression.py5180%9
   log.py90100% 
   utils.py30197%35
common/qconnector
   rabbitmq_connector.py451371%23–24, 37–49, 52–65
consumer
   event_consumer.py340100% 
pgoutput_parser
   base.py610100% 
   delete.py140100% 
   insert.py150100% 
   relation.py270100% 
   update.py190100% 
producer
   event_producer.py1482682%118–122, 215–217, 223–224, 229–235, 238–241, 244–245, 248–252
TOTAL4074190% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 0.237s ⏱️

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
common
   compression.py5180%9
   log.py90100% 
   utils.py280100% 
common/qconnector
   rabbitmq_connector.py451371%23–24, 37–49, 52–65
consumer
   event_consumer.py340100% 
pgoutput_parser
   base.py610100% 
   delete.py140100% 
   insert.py150100% 
   relation.py270100% 
   update.py190100% 
producer
   event_producer.py1481590%118–122, 215–217, 223–224, 245, 248–252
TOTAL4052993% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 0.268s ⏱️

@ashwin1111 ashwin1111 merged commit 5c50c5f into main Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants