Fix error logic (#17)

* Fixing Company ID allocation for Batch URLs * Fix Batch upload error logic --------- Co-authored-by: Shwetabh Kumar <[email protected]>
fylein · Jan 25, 2024 · 2545106 · 2545106
1 parent d8404f3
commit 2545106
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -11,6 +11,7 @@ __pycache__/
 
 # Mock Files
 dry_run.py
+test.py
 
 # Distribution / packaging
 .Python

diff --git a/dynamics/apis/api_base.py b/dynamics/apis/api_base.py
@@ -271,7 +271,7 @@ def _bulk_post_request(self, data, isolation: str, company_id: str = None, purch
         if response.status_code == 200 or response.status_code == 201:
             result = json.loads(response.text)
 
-            error_messages = [resp.get("body", {}).get("error", {}).get("message", None) for resp in result.get("responses", []) if resp.get("status", None) == 400]
+            error_messages = [resp.get('body', {}).get('error', {}).get('message', None) for resp in result.get('responses', []) if 400 <= resp.get('status', 0) < 500]
             error_messages = [message for message in error_messages if message is not None]
 
             if error_messages:

diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name='ms-dynamics-business-central-sdk',
-    version='1.4.0',
+    version='1.4.1',
     author='Shwetabh Kumar',
     author_email='[email protected]',
     description='Python SDK for accessing Dynamics APIs',
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,6 +11,7 @@ __pycache__/ @@
     # Mock Files
     dry_run.py
+    test.py
     # Distribution / packaging
     .Python
@@ Expand Down @@