Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert changes #399

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: Revert changes #399

merged 2 commits into from
Oct 14, 2024

Conversation

Ashutosh619-sudo
Copy link
Contributor

@Ashutosh619-sudo Ashutosh619-sudo commented Oct 14, 2024

Copy link

coderabbitai bot commented Oct 14, 2024

Walkthrough

The changes made in this pull request involve modifications to the logging_middleware.py and settings.py files, focusing on enhancing error logging and streamlining middleware functionality. The LogPostRequestMiddleware class has been removed, and the ErrorHandlerMiddleware class has been updated to improve error handling. Additionally, the requirements.txt file has been updated to downgrade specific package versions.

Changes

File Change Summary
fyle_xero_api/logging_middleware.py - Updated ErrorHandlerMiddleware to enhance error logging.
- Removed LogPostRequestMiddleware class and its methods.
fyle_xero_api/settings.py - Removed LogPostRequestMiddleware from the MIDDLEWARE list.
- Adjusted logging configuration by removing specific logger settings.
requirements.txt - Downgraded fyle from 0.37.2 to 0.37.0.
- Downgraded xerosdk from 0.14.2 to 0.14.1.

Possibly related PRs

Suggested reviewers

  • ashwin1111

Poem

🐰 In the meadow where logs do flow,
A middleware's gone, and now we know.
Errors logged with care and grace,
In our code, we'll find our place.
With versions set, we hop along,
To a brighter path, where we belong! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f1a84c8 and 174d96f.

📒 Files selected for processing (3)
  • fyle_xero_api/logging_middleware.py (0 hunks)
  • fyle_xero_api/settings.py (0 hunks)
  • requirements.txt (2 hunks)
💤 Files with no reviewable changes (2)
  • fyle_xero_api/logging_middleware.py
  • fyle_xero_api/settings.py
✅ Files skipped from review due to trivial changes (1)
  • requirements.txt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive)

1 similar comment
Copy link

PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive)

@Ashutosh619-sudo Ashutosh619-sudo changed the title Revert changes feat: Revert changes Oct 14, 2024
@Ashutosh619-sudo Ashutosh619-sudo changed the title feat: Revert changes fix: Revert changes Oct 14, 2024
Copy link

Tests Skipped Failures Errors Time
163 0 💤 0 ❌ 0 🔥 1m 10s ⏱️

@Ashutosh619-sudo Ashutosh619-sudo merged commit fb5ff1a into master Oct 14, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants