Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upate workspace last synced fix #320

Merged
merged 1 commit into from
Mar 6, 2024
Merged

upate workspace last synced fix #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions apps/fyle/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
from typing import Dict, List

from django.db import transaction
from fyle.platform.exceptions import (
InvalidTokenError as FyleInvalidTokenError,
RetryException,
)
from fyle.platform.exceptions import InvalidTokenError as FyleInvalidTokenError
from fyle.platform.exceptions import RetryException
from fyle_integrations_platform_connector import PlatformConnector

from apps.fyle.actions import create_generator_and_post_in_batches
Comment on lines 4 to 11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [143-143]

Logging sensitive information, such as workspace IDs, could potentially expose them in logs which might not be secure. While the logged message "Fyle credentials not found %s" is not directly logging sensitive information, it's a good practice to review what is being logged and ensure that no sensitive data is inadvertently exposed. Consider revising the logging strategy to minimize the risk of exposing sensitive information.

- logger.info("Fyle credentials not found %s", workspace_id)
+ logger.info("Fyle credentials not found for workspace ID: [REDACTED]")

Expand Down Expand Up @@ -103,7 +101,7 @@ def async_create_expense_groups(
)
)

if expenses:
if workspace.last_synced_at or expenses:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for updating workspace.last_synced_at is now based on whether this timestamp is already set or if there are any expenses. This change ensures that the timestamp is updated to the current time if either condition is met. However, it's important to ensure that this logic aligns with the intended behavior for all scenarios where expenses might be processed. Consider adding a comment explaining the rationale behind this condition to aid future maintainers.

workspace.last_synced_at = datetime.now()
reimbursable_expenses_count += len(expenses)

Expand All @@ -126,7 +124,7 @@ def async_create_expense_groups(
)
)

if len(expenses) != reimbursable_expenses_count:
if workspace.ccc_last_synced_at or len(expenses) != reimbursable_expenses_count:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, the update to workspace.ccc_last_synced_at is now contingent upon the timestamp being set or the number of expenses differing from the count of reimbursable expenses. This adjustment seems to target a more accurate update mechanism for credit card transactions. As with the previous suggestion, adding explanatory comments could enhance maintainability.

workspace.ccc_last_synced_at = datetime.now()

workspace.save()
Expand Down
Loading