-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct export lint fix #305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruuushhh
temporarily deployed
to
CI Environment
February 14, 2024 06:07 — with
GitHub Actions
Inactive
ruuushhh
temporarily deployed
to
CI Environment
February 14, 2024 06:07 — with
GitHub Actions
Inactive
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add-direct-export-scripts #305 +/- ##
============================================================
Coverage ? 93.85%
============================================================
Files ? 60
Lines ? 3613
Branches ? 0
============================================================
Hits ? 3391
Misses ? 222
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
ashwin1111
approved these changes
Feb 14, 2024
ruuushhh
temporarily deployed
to
CI Environment
February 14, 2024 07:55 — with
GitHub Actions
Inactive
ruuushhh
added a commit
that referenced
this pull request
Feb 14, 2024
* Add scripts for direct export * Fix comments * URL fix * Direct export lint fix (#305)
ruuushhh
added a commit
that referenced
this pull request
Feb 14, 2024
ruuushhh
added a commit
that referenced
this pull request
Feb 14, 2024
* Export View Direct export * fix * Update expense status in fyle (#302) * Update expense status in fyle * Resolve comments * URL fix * Add tests direct export (#303) * Add tests direct export * Add tests direct export * Add direct export scripts (#304) * Add scripts for direct export * Fix comments * URL fix * Direct export lint fix (#305)
ruuushhh
added a commit
that referenced
this pull request
Feb 14, 2024
* Model changes for Direct export * versions updated * Export View Direct export (#301) * Export View Direct export * fix * Update expense status in fyle (#302) * Update expense status in fyle * Resolve comments * URL fix * Add tests direct export (#303) * Add tests direct export * Add tests direct export * Add direct export scripts (#304) * Add scripts for direct export * Fix comments * URL fix * Direct export lint fix (#305)
ruuushhh
added a commit
that referenced
this pull request
Feb 14, 2024
* Post Integrations * Model changes for Direct export (#300) * Model changes for Direct export * versions updated * Export View Direct export (#301) * Export View Direct export * fix * Update expense status in fyle (#302) * Update expense status in fyle * Resolve comments * URL fix * Add tests direct export (#303) * Add tests direct export * Add tests direct export * Add direct export scripts (#304) * Add scripts for direct export * Fix comments * URL fix * Direct export lint fix (#305)
|
ruuushhh
added a commit
that referenced
this pull request
Feb 15, 2024
* Create admin subscriptions * Post Integrations (#299) * Post Integrations * Model changes for Direct export (#300) * Model changes for Direct export * versions updated * Export View Direct export (#301) * Export View Direct export * fix * Update expense status in fyle (#302) * Update expense status in fyle * Resolve comments * URL fix * Add tests direct export (#303) * Add tests direct export * Add tests direct export * Add direct export scripts (#304) * Add scripts for direct export * Fix comments * URL fix * Direct export lint fix (#305) * Uncomment for testing * Uncomment for testing * Updated the versions * Updated the versions * fix is_skipped * fix is_skipped * Adding Coverage tests (#307)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.