feat: Optimize Contacts Sync #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shwetabhk
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Shwetabhk
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 95.47% 95.43% -0.04%
==========================================
Files 57 57
Lines 3290 3285 -5
==========================================
- Hits 3141 3135 -6
- Misses 149 150 +1 ☔ View full report in Codecov by Sentry. |
ashwin1111
approved these changes
Nov 16, 2023
| if "EmailAddress" in customer | ||
| else None | ||
| }, | ||
| "active": True if customer["ContactStatus"] == "ACTIVE" else False, |
There was a problem hiding this comment.
this won't handle the delete case I think - if delete is not possible in Xero this is fine
Shwetabhk
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Shwetabhk
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Shwetabhk
added a commit
that referenced
this pull request
Nov 16, 2023
This reverts commit bcaa7ef.
Shwetabhk
added a commit
that referenced
this pull request
Nov 16, 2023
labhvam5
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.