Linting with flake8 #261
Merged
Linting with flake8 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
ruuushhh
reviewed
Sep 25, 2023
.flake8
Outdated
| E241, | ||
| E402, | ||
|
|
||
| exclude = apps/mappings/apps.py, apps/xero/admin.py |
There was a problem hiding this comment.
Why are we excluding these two files?
There was a problem hiding this comment.
they had imports like signal, django.contrib.admin which are needed but it was giving unused error.
There was a problem hiding this comment.
ignore those lines only by adding a comment in the previous line, don't ignore the whole file
ashwin1111
reviewed
Sep 26, 2023
.flake8
Outdated
| E241, | ||
| E402, | ||
|
|
||
| exclude = apps/mappings/apps.py, apps/xero/admin.py |
There was a problem hiding this comment.
assign back review once you fix this
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
ashwin1111
approved these changes
Sep 27, 2023
Ashutosh619-sudo
added
the
deploy
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Ashutosh619-sudo
temporarily deployed
to
Staging
GitHub Actions
Inactive
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 95.48% 95.42% -0.06%
==========================================
Files 57 57
Lines 3298 3259 -39
==========================================
- Hits 3149 3110 -39
Misses 149 149
☔ View full report in Codecov by Sentry. |
Ashutosh619-sudo
added
deploy
Ashutosh619-sudo
temporarily deployed
to
Staging
GitHub Actions
Inactive
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
ruuushhh
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.