Xero credential does not exist sentry error resolved (#229)

* Xero credential does not exist sentry error added * Platform error added * Platform error added * Pytest updated * Pytest resolved
fylein · Apr 24, 2023 · 9c892df · 9c892df
1 parent ee018b2
commit 9c892df
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml
@@ -21,7 +21,7 @@ jobs:
         run: |
           docker-compose -f docker-compose-pipeline.yml build
           docker-compose -f docker-compose-pipeline.yml up -d
-          docker-compose -f docker-compose-pipeline.yml exec -T api pytest tests/ --cov=. --cov-report=xml --cov-fail-under=97 --junit-xml=test-reports/report.xml
+          docker-compose -f docker-compose-pipeline.yml exec -T api pytest tests/ --cov=. --cov-report=xml --cov-fail-under=97 --junit-xml=test-reports/report.xml | tee pytest-coverage.txt
           echo "STATUS=$(cat pytest-coverage.txt | grep 'Required test' | awk '{ print $1 }')" >> $GITHUB_ENV
           echo "FAILED=$(cat test-reports/report.xml | awk -F'=' '{print $5}' | awk -F' ' '{gsub(/"/, "", $1); print $1}')" >> $GITHUB_ENV
         env:

diff --git a/apps/mappings/tasks.py b/apps/mappings/tasks.py
@@ -11,7 +11,7 @@
 
 from fyle_accounting_mappings.models import Mapping, MappingSetting, DestinationAttribute, ExpenseAttribute
 
-from fyle.platform.exceptions import WrongParamsError, InternalServerError, InvalidTokenError as FyleInvalidTokenError
+from fyle.platform.exceptions import WrongParamsError, InternalServerError, InvalidTokenError as FyleInvalidTokenError, PlatformError
 
 from xerosdk.exceptions import UnsuccessfulAuthentication, InvalidGrant
 
@@ -178,6 +178,12 @@ def auto_create_category_mappings(workspace_id):
     except InternalServerError:
         logger.error('Internal server error while importing to Fyle')
 
+    except PlatformError as exception:
+        logger.error(
+            'Platform error - %s in Fyle %s %s',
+            workspace_id, exception.message, {'error': exception.response}
+        )
+
     except Exception:
         error = traceback.format_exc()
         error = {

diff --git a/apps/xero/tasks.py b/apps/xero/tasks.py
@@ -426,6 +426,8 @@ def create_chain_and_export(chaining_attributes: list, workspace_id: int) -> Non
 
     except UnsuccessfulAuthentication:
         logger.info('Xero refresh token is invalid for workspace_id - %s', workspace_id)
+    except XeroCredentials.DoesNotExist:
+        logger.info('Xero Credentials not found for workspace_id %s',workspace_id)
 
 def schedule_bills_creation(workspace_id: int, expense_group_ids: List[str]) -> list:
     """