delete corporate card mapping bug fix (#206)

* delete corporate card mapping bug fix * moving function call to trigger * removing line * resolving comments
fylein · Jan 31, 2023 · 4188259 · 4188259
1 parent ff56996
commit 4188259
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/apps/workspaces/apis/export_settings/triggers.py b/apps/workspaces/apis/export_settings/triggers.py
@@ -1,6 +1,7 @@
 from apps.mappings.tasks import schedule_auto_map_employees
 from apps.workspaces.models import WorkspaceGeneralSettings
 from fyle_accounting_mappings.models import MappingSetting
+from apps.workspaces.utils import delete_cards_mapping_settings
 
 
 class ExportSettingsTrigger:
@@ -23,5 +24,7 @@ def run_workspace_general_settings_triggers(workspace_general_settings_instance:
             }
         )
 
+        delete_cards_mapping_settings(workspace_general_settings_instance)
+
         schedule_auto_map_employees(workspace_general_settings_instance.auto_map_employees,
             workspace_general_settings_instance.workspace_id)
diff --git a/apps/workspaces/utils.py b/apps/workspaces/utils.py
@@ -233,3 +233,14 @@ def generate_xero_identity(authorization_code: str, redirect_uri: str) -> str:
 
     elif response.status_code == 500:
         raise InternalServerError('Internal server error', response.text)
+
+
+def delete_cards_mapping_settings(workspace_general_settings: WorkspaceGeneralSettings):
+    if not workspace_general_settings.corporate_credit_card_expenses_object:
+        mapping_setting = MappingSetting.objects.filter(
+            workspace_id=workspace_general_settings.workspace_id,
+            source_field='CORPORATE_CARD',
+            destination_field='BANK_ACCOUNT'
+        ).first()
+        if mapping_setting:
+            mapping_setting.delete()