Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct payload function for purchase invoice #91

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

NileshPant1999
Copy link
Contributor

No description provided.

Copy link

Tests Skipped Failures Errors Time
22 0 💤 1 ❌ 0 🔥 3.204s ⏱️

Copy link

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 2.773s ⏱️

@ashwin1111 ashwin1111 removed their request for review November 23, 2023 07:05
@@ -23,6 +23,8 @@ class Sage300FieldsView(generics.ListAPIView):
"""
serializer_class = Sage300FieldSerializer
pagination_class = None
permission_classes = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

@@ -23,6 +23,8 @@ class Sage300FieldsView(generics.ListAPIView):
"""
serializer_class = Sage300FieldSerializer
pagination_class = None
permission_classes = []
authentication_classes = []

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 2.609s ⏱️

@codecov-commenter
Copy link

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (904dd8d) 72.49% compared to head (27ca1cf) 72.42%.

Files Patch % Lines
apps/sage300/exports/base_model.py 12.50% 14 Missing ⚠️
apps/sage300/exports/purchase_invoice/models.py 0.00% 8 Missing ⚠️
sage_desktop_sdk/apis/documents.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           update-basemodel-methods      #91      +/-   ##
============================================================
- Coverage                     72.49%   72.42%   -0.07%     
============================================================
  Files                            64       64              
  Lines                          2759     2763       +4     
============================================================
+ Hits                           2000     2001       +1     
- Misses                          759      762       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NileshPant1999 NileshPant1999 merged commit f745e0e into update-basemodel-methods Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants