Function to populate purchase invoice #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-sage-desktop-api into function-to-populate-purchase-invoice
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
…le-sage-desktop-api into function-to-populate-purchase-invoice
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
…le-sage-desktop-api into function-to-populate-purchase-invoice
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## purchace-invoice-model #86 +/- ##
==========================================================
- Coverage 75.51% 72.42% -3.10%
==========================================================
Files 63 64 +1
Lines 2614 2763 +149
==========================================================
+ Hits 1974 2001 +27
- Misses 640 762 +122 ☔ View full report in Codecov by Sentry. |
Shwetabhk
reviewed
Nov 27, 2023
| description = self.get_expense_purpose(accounting_export.workspace_id, lineitem, lineitem.category, advance_setting) | ||
|
|
||
| if dependent_field_setting: | ||
| cost_category_id = self.get_cost_category_id_or_none(accounting_export, lineitem, dependent_field_setting, job_id) |
There was a problem hiding this comment.
function name seems wrong, it should be get_cost_category_id
Shwetabhk
approved these changes
Nov 27, 2023
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.