Mapping settings added to import settings #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruuushhh
had a problem deploying
to
CI Environment
GitHub Actions
Failure
ruuushhh
had a problem deploying
to
CI Environment
GitHub Actions
Failure
ruuushhh
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ruuushhh
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ruuushhh
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ruuushhh
commented
Nov 6, 2023
| from typing import Dict, List | ||
| from django.db.models import Q | ||
|
|
||
| # from apps.mappings.helpers import schedule_or_delete_fyle_import_tasks |
There was a problem hiding this comment.
This is fixed in next PR
ruuushhh
commented
Nov 6, 2023
| ) | ||
| mapping_settings = validated.pop('mapping_settings') | ||
| import_settings = validated.pop('import_settings') | ||
| # dependent_field_settings = validated.pop('dependent_field_settings') |
There was a problem hiding this comment.
This is fixed in next PR
ruuushhh
commented
Nov 6, 2023
| # dependent_field_settings = validated.pop('dependent_field_settings') | ||
|
|
||
| with transaction.atomic(): | ||
| print("inside function") |
NileshPant1999
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.