Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 2: add support for expense group sync #73

Merged

Conversation

NileshPant1999
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 6, 2023

Tests Skipped Failures Errors Time
20 0 💤 3 ❌ 0 🔥 3.030s ⏱️

Copy link

github-actions bot commented Nov 6, 2023

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 3.700s ⏱️

Copy link

github-actions bot commented Nov 7, 2023

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 3.928s ⏱️

@NileshPant1999 NileshPant1999 changed the title add support for expense group sync PR 2: add support for expense group sync Nov 7, 2023
@NileshPant1999 NileshPant1999 changed the base branch from master to create-accounting-export-methods November 7, 2023 11:21
Copy link

github-actions bot commented Nov 7, 2023

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 3.958s ⏱️

Copy link

github-actions bot commented Nov 7, 2023

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 2.270s ⏱️

Copy link

github-actions bot commented Nov 7, 2023

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 3.074s ⏱️

Copy link

github-actions bot commented Nov 7, 2023

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 2.413s ⏱️

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (636a515) 73.47% compared to head (3d7d112) 72.53%.
Report is 1 commits behind head on create-accounting-export-methods.

❗ Current head 3d7d112 differs from pull request most recent head 0816f98. Consider uploading reports for the commit 0816f98 to get more accurate results

Additional details and impacted files
@@                         Coverage Diff                          @@
##           create-accounting-export-methods      #73      +/-   ##
====================================================================
- Coverage                             73.47%   72.53%   -0.95%     
====================================================================
  Files                                    51       54       +3     
  Lines                                  2236     2312      +76     
====================================================================
+ Hits                                   1643     1677      +34     
- Misses                                  593      635      +42     
Files Coverage Δ
apps/fyle/models.py 89.88% <100.00%> (+1.12%) ⬆️
apps/fyle/views.py 92.50% <50.00%> (-7.50%) ⬇️
apps/fyle/queue.py 33.33% <33.33%> (ø)
apps/fyle/exceptions.py 37.93% <37.93%> (ø)
apps/fyle/tasks.py 47.05% <47.05%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


accounting_export.save()

except FyleCredential.DoesNotExist:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user decorator for error handling

"""
try:
# Get export settings to determine Expense State
export_settings = ExportSetting.objects.get(workspace_id=workspace_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move all the functionality to a common function

Copy link

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 2.631s ⏱️

Copy link

Tests Skipped Failures Errors Time
20 0 💤 0 ❌ 0 🔥 3.771s ⏱️

@NileshPant1999 NileshPant1999 merged commit 0cb3461 into create-accounting-export-methods Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants