-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR 2: add support for expense group sync #73
PR 2: add support for expense group sync #73
Conversation
|
|
|
…/fylein/fyle-sage-desktop-api into accounting-export-sync
|
|
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## create-accounting-export-methods #73 +/- ##
====================================================================
- Coverage 73.47% 72.53% -0.95%
====================================================================
Files 51 54 +3
Lines 2236 2312 +76
====================================================================
+ Hits 1643 1677 +34
- Misses 593 635 +42
☔ View full report in Codecov by Sentry. |
apps/fyle/tasks.py
Outdated
|
||
accounting_export.save() | ||
|
||
except FyleCredential.DoesNotExist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user decorator for error handling
apps/fyle/tasks.py
Outdated
""" | ||
try: | ||
# Get export settings to determine Expense State | ||
export_settings = ExportSetting.objects.get(workspace_id=workspace_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move all the functionality to a common function
|
|
0cb3461
into
create-accounting-export-methods
No description provided.