Base Structure for Import of Sage300 Attributes to Fyle #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage ? 86.07%
=========================================
Files ? 31
Lines ? 1070
Branches ? 0
=========================================
Hits ? 921
Misses ? 149
Partials ? 0 ☔ View full report in Codecov by Sentry. |
NileshPant1999
commented
Oct 26, 2023
| @@ -14,7 +14,7 @@ django-request-logging==0.7.5 | |||
| django-filter==21.1 | |||
|
|
|||
| # DjangoQ for running async tasks | |||
| django-q2==1.6.1 | |||
| django-q==1.3.9 | |||
There was a problem hiding this comment.
@Shwetabhk django-q2 is not working with other versions of Django-q which is installed in other libraries such as fyle rest auth etc
we either need to update everywhere, right now rolled back to latest version of django-q
NileshPant1999
commented
Oct 26, 2023
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('workspaces', '0001_initial'), |
There was a problem hiding this comment.
do you want me to delete this parent migration and create migration again, or this is okay ??
There was a problem hiding this comment.
@Shwetabhk ignore this, this will be fixed in other pr
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Shwetabhk
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.