api for fyle expense custom field #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
=========================================
Coverage ? 85.34%
=========================================
Files ? 30
Lines ? 1017
Branches ? 0
=========================================
Hits ? 868
Misses ? 149
Partials ? 0 ☔ View full report in Codecov by Sentry. |
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
|
NileshPant1999
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Shwetabhk
reviewed
Oct 25, 2023
apps/fyle/views.py
Outdated
| """ | ||
| Custom Field view | ||
| """ | ||
| def get(self, request, *args, **kwargs): |
There was a problem hiding this comment.
can we please put this in serializer?
Rushikesh user MethodSerializer somewhere to do something similar, please check it out
Shwetabhk
approved these changes
Oct 25, 2023
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Shwetabhk
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.