Job, Dep Field code-prepending support #206

Hrishabh17 · 2024-07-16T13:42:26Z

No description provided.

coderabbitai · 2024-07-16T13:42:35Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-07-16T13:44:11Z

Tests	Skipped	Failures	Errors	Time
136	0 💤	6 ❌	0 🔥	7.946s ⏱️

github-actions · 2024-07-16T14:14:12Z

Tests	Skipped	Failures	Errors	Time
136	0 💤	6 ❌	0 🔥	8.078s ⏱️

apps/mappings/imports/modules/base.py

apps/sage300/dependent_fields.py

apps/sage300/helpers.py

apps/sage300/models.py

apps/sage300/utils.py

github-actions · 2024-07-17T05:26:50Z

Tests	Skipped	Failures	Errors	Time
136	0 💤	7 ❌	0 🔥	8.328s ⏱️

github-actions · 2024-07-17T06:13:59Z

Tests	Skipped	Failures	Errors	Time
137	0 💤	0 ❌	0 🔥	10.513s ⏱️

github-actions · 2024-07-17T11:31:13Z

Tests	Skipped	Failures	Errors	Time
138	0 💤	0 ❌	0 🔥	11.802s ⏱️

github-actions · 2024-07-17T11:45:19Z

Tests	Skipped	Failures	Errors	Time
138	0 💤	0 ❌	0 🔥	12.022s ⏱️

github-actions · 2024-07-17T15:11:55Z

Tests	Skipped	Failures	Errors	Time
138	0 💤	1 ❌	0 🔥	12.092s ⏱️

github-actions · 2024-07-17T15:22:42Z

Tests	Skipped	Failures	Errors	Time
138	0 💤	0 ❌	0 🔥	11.518s ⏱️

github-actions · 2024-07-18T06:54:47Z

Tests	Skipped	Failures	Errors	Time
142	0 💤	0 ❌	0 🔥	12.014s ⏱️

github-actions · 2024-07-18T13:53:07Z

Tests	Skipped	Failures	Errors	Time
142	0 💤	0 ❌	0 🔥	11.707s ⏱️

apps/mappings/helpers.py

apps/sage300/dependent_fields.py

apps/mappings/helpers.py

github-actions · 2024-07-20T14:04:57Z

Tests	Skipped	Failures	Errors	Time
142	0 💤	0 ❌	0 🔥	11.501s ⏱️

* add support for code prepending in CATEGORY * rename the helper method * rename the helper method * add support for code prepending in MERCHANT (#209) * add support for code prepending in MERCHANT * change the callback methods are sent * bug fix * rename the helper method * fix callback method mapping of vendor * Code naming support cost center (#210) * add support for code prepending in COST_CENTER * rename the helper method * add support for code prepending in CUSTOM attribute (#211) * add support for code prepending in CUSTOM attribute * improve test case

github-actions · 2024-07-23T06:58:51Z

Tests	Skipped	Failures	Errors	Time
152	0 💤	0 ❌	0 🔥	12.393s ⏱️

…T_CENTER, CUSTOM fields (#205) * add import_code_fields, test cases * fix param name * add condition before adding dep fields * add condition before adding dep fields * Job, Dep Field code-prepending support (#206) * Job, Dep Field code-prepending support * auto map feature * fix comments - add util func, handle code in VENDOR_TYPE * fix existing test cases * Add check for syncing jobs, deps and add test cases * update func name * added unit tests * fix failing test * add project import related test cases * fix lint * remove redundant db calls * rename helper func, fix is_job_sync_allowed method * add support for code prepending in CATEGORY (#208) * add support for code prepending in CATEGORY * rename the helper method * rename the helper method * add support for code prepending in MERCHANT (#209) * add support for code prepending in MERCHANT * change the callback methods are sent * bug fix * rename the helper method * fix callback method mapping of vendor * Code naming support cost center (#210) * add support for code prepending in COST_CENTER * rename the helper method * add support for code prepending in CUSTOM attribute (#211) * add support for code prepending in CUSTOM attribute * improve test case * add test cases (#212) * Job, Dep Field code-prepending support * auto map feature * fix comments - add util func, handle code in VENDOR_TYPE * fix existing test cases * Add check for syncing jobs, deps and add test cases * update func name * added unit tests * fix failing test * add project import related test cases * fix lint * remove redundant db calls * add support for code prepending in CATEGORY * add support for code prepending in MERCHANT * change the callback methods are sent * bug fix * add support for code prepending in COST_CENTER * rename helper func, fix is_job_sync_allowed method * rename the helper method * rename the helper method * rename the helper method * fix callback method mapping of vendor * rename the helper method * add support for code prepending in CUSTOM attribute * improve test case * add test cases * method refactor * add validation for adding code post import (#214) * add validation for adding code post import * add loggers * remove mapping, refactor validations (#215) * remove mapping, refactor validations * fix lint * Add code_prepend support in export (#216) * Add code_prepend support in export * code-prepend changes in custom fields * fix 500 internal error (#217) * remove unnecessary check * optimize the api call * optimize the query * add api for import config (#218) * refactor project callback func, dep field func * add additional condition for updating the dependent field setting last import flag * bump accounting mapping version * remove print stmt, remove mapping condition * add delimiter in the imported field

Job, Dep Field code-prepending support

f7b28b0

Hrishabh17 had a problem deploying to CI Environment July 16, 2024 13:42 — with GitHub Actions Failure

auto map feature

d8d6be3

Hrishabh17 had a problem deploying to CI Environment July 16, 2024 14:12 — with GitHub Actions Failure

Hrishabh17 requested a review from ashwin1111 July 16, 2024 14:16

ashwin1111 reviewed Jul 16, 2024

View reviewed changes

fix comments - add util func, handle code in VENDOR_TYPE

c6abe7e

Hrishabh17 had a problem deploying to CI Environment July 17, 2024 05:25 — with GitHub Actions Failure

fix existing test cases

ab91b34

Hrishabh17 temporarily deployed to CI Environment July 17, 2024 06:12 — with GitHub Actions Inactive

Add check for syncing jobs, deps and add test cases

2a6c29a

Hrishabh17 temporarily deployed to CI Environment July 17, 2024 11:29 — with GitHub Actions Inactive

update func name

ad44ea7

Hrishabh17 temporarily deployed to CI Environment July 17, 2024 11:43 — with GitHub Actions Inactive

added unit tests

4413e56

Hrishabh17 had a problem deploying to CI Environment July 17, 2024 15:10 — with GitHub Actions Failure

fix failing test

37445f9

Hrishabh17 temporarily deployed to CI Environment July 17, 2024 15:21 — with GitHub Actions Inactive

add project import related test cases

bfcc8b0

Hrishabh17 had a problem deploying to CI Environment July 18, 2024 06:50 — with GitHub Actions Failure

fix lint

5d832de

Hrishabh17 temporarily deployed to CI Environment July 18, 2024 06:53 — with GitHub Actions Inactive

Hrishabh17 requested a review from ashwin1111 July 18, 2024 09:23

remove redundant db calls

7da3f6e

Hrishabh17 temporarily deployed to CI Environment July 18, 2024 13:51 — with GitHub Actions Inactive

ashwin1111 approved these changes Jul 19, 2024

View reviewed changes

apps/mappings/helpers.py Outdated Show resolved Hide resolved

apps/sage300/dependent_fields.py Outdated Show resolved Hide resolved

apps/sage300/dependent_fields.py Outdated Show resolved Hide resolved

apps/mappings/helpers.py Outdated Show resolved Hide resolved

rename helper func, fix is_job_sync_allowed method

2cc2294

Hrishabh17 temporarily deployed to CI Environment July 20, 2024 14:03 — with GitHub Actions Inactive

Hrishabh17 temporarily deployed to CI Environment July 23, 2024 06:57 — with GitHub Actions Inactive

Hrishabh17 merged commit 4c99385 into import-settings-changes Jul 23, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Job, Dep Field code-prepending support #206

Job, Dep Field code-prepending support #206

Hrishabh17 commented Jul 16, 2024

coderabbitai bot commented Jul 16, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jul 16, 2024

github-actions bot commented Jul 16, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 18, 2024

github-actions bot commented Jul 18, 2024

github-actions bot commented Jul 20, 2024

github-actions bot commented Jul 23, 2024

Job, Dep Field code-prepending support #206

Job, Dep Field code-prepending support #206

Conversation

Hrishabh17 commented Jul 16, 2024

coderabbitai bot commented Jul 16, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jul 16, 2024

github-actions bot commented Jul 16, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 18, 2024

github-actions bot commented Jul 18, 2024

github-actions bot commented Jul 20, 2024

github-actions bot commented Jul 23, 2024

coderabbitai bot commented Jul 16, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)