Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header amount #182

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Fix header amount #182

merged 9 commits into from
Jun 4, 2024

Conversation

Hrishabh17
Copy link
Contributor

@Hrishabh17 Hrishabh17 commented Jun 4, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Ensured all monetary values in purchase invoices are rounded to two decimal places for improved accuracy and consistency.

Copy link

coderabbitai bot commented Jun 4, 2024

Walkthrough

The recent changes in the sage300 app's purchase_invoice module focus on ensuring that all monetary amounts are consistently rounded to two decimal places. This adjustment has been applied in both the __construct_purchase_invoice method in tasks.py and the create_or_update_object method in models.py. These modifications enhance precision in financial transactions and data consistency.

Changes

File Change Summary
apps/sage300/exports/purchase_invoice/tasks.py Rounded body.amount to two decimal places before assigning it to the 'Amount' field in the payload.
apps/sage300/exports/purchase_invoice/models.py Rounded amount and lineitem.amount to two decimal places before assigning them in the method.

Sequence Diagram(s) (Beta)

The changes are too simple and varied to generate a meaningful sequence diagram.

Poem

In the world of Sage, amounts now round,
Precision in numbers, firmly found.
Two decimal places, no more, no less,
Ensuring our invoicing is free from mess.
Let's toast to clarity, with data so sound,
In the realm of finance, where order is crowned.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jun 4, 2024

Tests Skipped Failures Errors Time
129 0 💤 0 ❌ 0 🔥 9.776s ⏱️

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 73a5b3a and 9856a80.

Files selected for processing (1)
  • apps/sage300/exports/purchase_invoice/tasks.py (1 hunks)
Additional comments not posted (2)
apps/sage300/exports/purchase_invoice/tasks.py (2)

Line range hint 106-106: Proper use of exception handling in create_purchase_invoice.


72-72: Ensure rounding is appropriate for all use cases.

@Hrishabh17 Hrishabh17 requested a review from ashwin1111 June 4, 2024 06:11
Copy link

github-actions bot commented Jun 4, 2024

Tests Skipped Failures Errors Time
129 0 💤 0 ❌ 0 🔥 10.182s ⏱️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (bf082be) to head (a3aa900).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   94.80%   94.66%   -0.15%     
==========================================
  Files          99      100       +1     
  Lines        5235     5395     +160     
==========================================
+ Hits         4963     5107     +144     
- Misses        272      288      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9856a80 and a3aa900.

Files selected for processing (1)
  • apps/sage300/exports/purchase_invoice/models.py (2 hunks)
Additional context used
Ruff
apps/sage300/exports/purchase_invoice/models.py

107-107: Comparison to None should be cond is None

Additional comments not posted (2)
apps/sage300/exports/purchase_invoice/models.py (2)

52-52: Rounding of the amount ensures consistent monetary values, aligning with the PR objectives.


146-146: Rounding of line item amounts ensures consistent monetary values, aligning with the PR objectives.

@Hrishabh17 Hrishabh17 merged commit daaf60c into master Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants