chore: Revert "fix: add unique constraint in task_logs for expense_group, add interval for next run (#690)"

[Hrishabh17]

This reverts commit d1d12fd.

Clickup

https://app.clickup.com/

Summary by CodeRabbit

• New Features

  • Modified the TaskLog model to allow multiple entries to reference the same ExpenseGroup.

• Bug Fixes

  • Improved the schedule_sync function by simplifying scheduling logic and removing unnecessary complexity.
  • Updated user management to prevent the current user from being added as an admin again.

• Chores

  • Removed unused import statement for timedelta.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves the deletion of a Django migration file that modified the expense_group field in the tasklog model, which was previously set as a unique foreign key. The change allows for non-unique associations between TaskLog entries and ExpenseGroup. Additionally, modifications were made to the schedule_sync function in the tasks.py file to simplify scheduling logic and prevent redundant admin additions, while ensuring existing error handling remains intact.

Changes

File Path	Change Summary
apps/tasks/migrations/0012_alter_tasklog_expense_group.py	Deleted migration file that modified the expense_group field in tasklog, removing unique constraint.
apps/tasks/models.py	Updated TaskLog model to remove unique=True from expense_group field declaration.
apps/workspaces/tasks.py	Simplified schedule_sync function by removing next_run logic and updated async_add_admins_to_workspace to prevent redundant admin addition.

Possibly related PRs

• fix: add unique constraint in task_logs for expense_group, add interval for next run #690: This PR adds a unique constraint to the expense_group field in the tasklog model, which directly relates to the changes made in the main PR that removed the unique constraint from the same field.

Suggested reviewers

• ashwin1111

Poem

In the fields where tasks do hop,
The logs now dance, no longer stop.
Expense groups can share their space,
As rabbits bound with joyful grace.
Simplified syncs, a smoother ride,
In our burrow, we take pride! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive)

[github-actions]

PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive)

[github-actions]

Tests	Skipped	Failures	Errors	Time
261	0 💤	0 ❌	0 🔥	55.068s ⏱️

[github-actions]

Tests	Skipped	Failures	Errors	Time
261	0 💤	0 ❌	0 🔥	59.679s ⏱️