feat: Added loggers in sdk and changed version #682
Conversation
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
WalkthroughThe changes involve updates to two files: Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
fyle_qbo_api/settings.py
Outdated
| @@ -144,6 +144,11 @@ | |||
| 'handlers': ['console'], | |||
| 'level': 'INFO', | |||
| }, | |||
| 'qbosdk.apis.api_base': { | |||
| 'handlers': ['console'], | |||
| 'level': 'DEBUG', | |||
There was a problem hiding this comment.
let's do INFO by default. When we bash and run some scripts, we can have it DEBUG.
import logging
logger = logging.getLogger('qbosdk.apis.api_base')
logger.setLevel(logging.DEBUG)
<rest of script>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
fyle_qbo_api/settings.py (1)
147-151: LGTM! Consider adding a comment for clarity.The new logger configuration for 'qbosdk.apis.api_base' looks good. It follows the suggestion from the previous review to use INFO level by default. The use of the 'console' handler and enabling propagation are consistent with good logging practices.
For consistency with other parts of the configuration, consider adding a brief comment explaining the purpose of this logger:
'qbosdk.apis.api_base': { # Logger for QuickBooks Online SDK API base 'handlers': ['console'], 'level': 'INFO', 'propagate': True },
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
- Coverage 94.70% 94.49% -0.22%
==========================================
Files 61 61
Lines 4801 4920 +119
==========================================
+ Hits 4547 4649 +102
- Misses 254 271 +17 |
* feat: Added loggers in sdk and changed version * comment resolved * bump up fyle-rest-auth and fyle platform version
* feat: Added loggers in sdk and changed version * comment resolved * bump up fyle-rest-auth and fyle platform version
Description
Please add PR description here, add screenshots if needed
Clickup
Please add link here
https://app.clickup.com/1864988/v/l/6-901603904304-1
Summary by CodeRabbit
New Features
Chores
qbosdkpackage version to ensure compatibility and access to the latest features.fylepackage version for improved functionality.fyle-rest-authpackage version for better performance.