fix: Bill Number (Add Safety) #672
Conversation
ruuushhh
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
ruuushhh
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
WalkthroughThe changes involve an update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
apps/quickbooks_online/models.py (1)
194-197: Approved: Bill number uniqueness improvementThe changes effectively implement a safety check for bill numbers by appending a count when duplicates are found. This aligns well with the PR objective and should prevent duplicate bill numbers in most cases.
Consider using a database transaction or a more robust locking mechanism to handle potential race conditions in concurrent requests. This could prevent the rare case where two simultaneous requests might generate the same bill number. For example:
from django.db import transaction @transaction.atomic def get_bill_number(expense_group: ExpenseGroup): # ... existing code ... with transaction.atomic(): count = Bill.objects.filter(bill_number=bill_number, expense_group__workspace_id=expense_group.workspace.id).count() if count > 0: bill_number = '{} - {}'.format(bill_number, count + 1) # Create the Bill object here to ensure uniqueness Bill.objects.create(bill_number=bill_number, expense_group=expense_group) return bill_numberThis approach would ensure that the bill number generation and creation are atomic operations, preventing potential conflicts in high-concurrency scenarios.
|
|
Co-authored-by: GitHub Actions <[email protected]>
Description
Add Safety Check for Bills
If Bill Number exists in DB then add count to it
Clickup
ADMIN | ARR $3,598 | QBO Error - Duplicate Document Number
Summary by CodeRabbit
New Features
Bug Fixes