implementation #544
Merged
implementation #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labhvam5
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
labhvam5
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
ashwin1111
approved these changes
Dec 20, 2023
apps/mappings/schedules.py
Outdated
| @@ -31,7 +32,9 @@ def schedule_or_delete_fyle_import_tasks(workspace_general_settings: WorkspaceGe | |||
| ) | |||
|
|
|||
| else: | |||
| # Have added the TAX_GROUP in not case because the mapping_settings persists even after import_tax_codes is set to False | |||
There was a problem hiding this comment.
can we remove tax group row in mapping settings if tax is set to false? feel like a bad data is present in db
labhvam5
had a problem deploying
to
CI Environment
GitHub Actions
Failure
labhvam5
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
labhvam5
added a commit
that referenced
this pull request
Dec 26, 2023
* ImportTax + Vendors : Scheduling * resolving comments * implementation (#544) * implementation * adding tax condition * resolving comments * Removing old code (#545) * Removing old code * Adding test (#546) * resolving comments * resolving comments * adding test * removing dead code * removing dead code * fixing import * Migration script (#547) * Migration script * combining scripts into one * changing sub module to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.