ExpenseCustomField Rework #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labhvam5
had a problem deploying
to
CI Environment
GitHub Actions
Failure
labhvam5
had a problem deploying
to
CI Environment
GitHub Actions
Failure
labhvam5
commented
Dec 18, 2023
| @@ -99,10 +98,6 @@ def pre_save_mapping_settings(self): | |||
| """ | |||
| mapping_settings = self.__mapping_settings | |||
|
|
|||
| schedule_fyle_attributes_creation(self.__workspace_id) | |||
There was a problem hiding this comment.
We have removed the scheduling logic from imports/triggers to mappings/signals.py . Hope this doesn't cause any issue.
ashwin1111
reviewed
Dec 18, 2023
| workspace_id=workspace_general_settings.workspace_id, | ||
| is_custom=True | ||
| ).count() | ||
|
|
There was a problem hiding this comment.
we're calling schedule_or_delete_fyle_import_tasks() from 2 places
mapping setting post save signal and post_save_mapping_settings trigger in onboarding API
I think we can remove mapping setting post save signal
There was a problem hiding this comment.
able to get the issue have removed the mapping setting post save signal
apps/mappings/schedules.py
Outdated
| @@ -34,8 +34,15 @@ def schedule_or_delete_fyle_import_tasks(workspace_general_settings: WorkspaceGe | |||
| source_field__in=['PROJECT', 'COST_CENTER'] | |||
| ).count() | |||
|
|
|||
| custom_field_import_fields_count = MappingSetting.objects.filter( | |||
There was a problem hiding this comment.
cleanup the whole function. if something: schedule. else: delete
labhvam5
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
labhvam5
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
ashwin1111
approved these changes
Dec 19, 2023
labhvam5
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
labhvam5
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 96.26% 96.10% -0.16%
==========================================
Files 60 60
Lines 4467 4395 -72
==========================================
- Hits 4300 4224 -76
- Misses 167 171 +4
|
labhvam5
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.