Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category-rework: Implementation #524

Merged
merged 13 commits into from
Dec 6, 2023
Merged

Conversation

labhvam5
Copy link
Contributor

No description provided.

Copy link

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 1 🔥 1.236s ⏱️

Copy link

github-actions bot commented Dec 1, 2023

Tests Skipped Failures Errors Time
216 0 💤 3 ❌ 0 🔥 51.137s ⏱️

if workspace_general_settings.import_items:
items_sync_method = [SYNC_METHODS['ITEM']]
if destination_sync_methods:
destination_sync_methods = destination_sync_methods.append(SYNC_METHODS['ITEM']) if destination_sync_methods else items_sync_method
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a=[1]
a=a.append(2)
a
print(a)
None

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if workspace_general_settings.import_categories or workspace_general_settings.import_items:
    destination_sync_methods = []
    if workspace_general_settings.import_categories:
        destination_sync_methods.append(SYNC_METHODS['ACCOUNT'])
    if workspace_general_settings.import_items:
        destination_sync_methods.append(SYNC_METHODS['ITEM'])

Copy link

github-actions bot commented Dec 3, 2023

Tests Skipped Failures Errors Time
216 0 💤 3 ❌ 0 🔥 50.630s ⏱️

* Disabling categories when import-items in disabled

* sub-module changes

* adding latest chahnges

* adding latest submodule commit

* remooving unnecessary changes

* Removing old code + test (#530)

* Reomving old code

* removing code

* lint fix

* new commit

* changing sub module commit

* adding test

* adding test

* lint fix

* adding test to increase cov

* adding migration script

* removing the construct test

* lint fix

* resolve comments
Copy link

github-actions bot commented Dec 6, 2023

Tests Skipped Failures Errors Time
217 0 💤 0 ❌ 0 🔥 44.337s ⏱️

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (import-categories-0@a51658b). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             import-categories-0     #524   +/-   ##
======================================================
  Coverage                       ?   96.26%           
======================================================
  Files                          ?       60           
  Lines                          ?     4470           
  Branches                       ?        0           
======================================================
  Hits                           ?     4303           
  Misses                         ?      167           
  Partials                       ?        0           

@labhvam5 labhvam5 merged commit e463a9f into import-categories-0 Dec 6, 2023
3 checks passed
labhvam5 added a commit that referenced this pull request Dec 13, 2023
* Category-rework: scheduling

* adding items support for scheduling

* resloving comment

* lint fix

* Category-rework: Implementation (#524)

* Category-rework: Implementation

* adding sync_methods as array

* adding charts_of_accounts support

* sub module commit change

* script changes

* cahnges for chart-of-accounts

* sub module commit changes

* lint fix

* sub module commit change

* resolving comments

* Disabling categories when import-items in disabled (#527)

* Disabling categories when import-items in disabled

* sub-module changes

* adding latest chahnges

* adding latest submodule commit

* remooving unnecessary changes

* Removing old code + test (#530)

* Reomving old code

* removing code

* lint fix

* new commit

* changing sub module commit

* adding test

* adding test

* lint fix

* adding test to increase cov

* adding migration script

* removing the construct test

* lint fix

* resolve comments

* chanign sub module commit

* fixing projects scheduling logic

* changes for disabling logic

* sub module commit changes

* changing sub module to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants