Fix pagination and post summary grouped by fund source #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin1111
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Shwetabhk
reviewed
Oct 13, 2023
apps/fyle/tasks.py
Outdated
| @@ -166,26 +165,32 @@ def sync_dimensions(fyle_credentials): | |||
| logger.info('Invalid Token for fyle') | |||
|
|
|||
|
|
|||
| def post_accounting_export_summary(org_id: str, workspace_id: int) -> None: | |||
| def post_accounting_export_summary(org_id: str, workspace_id: int, fund_source: str=None) -> None: | |||
There was a problem hiding this comment.
Suggested change
| def post_accounting_export_summary(org_id: str, workspace_id: int, fund_source: str=None) -> None: | |
| def post_accounting_export_summary(org_id: str, workspace_id: int, fund_source: str = None) -> None: |
ashwin1111
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Shwetabhk
approved these changes
Oct 13, 2023
* add and fix tests * fix lint * fix lint
ashwin1111
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
added a commit
that referenced
this pull request
Oct 13, 2023
* Add support for receiving webhook event * Add tests for new addition (#500) * Add tests for new addition * Fix pagination and post summary grouped by fund source (#501) * Fix pagination and post summary grouped by fund source * remove generator and use list of list * add and fix tests (#502) * add and fix tests * fix lint * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.