Duplicate vendor exists, Platform connector error resolved (#417)

* Duplicate vendor exists, Platform connector error resolved * Sentry errors resolved --------- Co-authored-by: Ashwin Thanaraj <[email protected]>
fylein · Apr 27, 2023 · fc40089 · fc40089
1 parent cc2482f
commit fc40089
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/apps/fyle/tasks.py b/apps/fyle/tasks.py
@@ -7,6 +7,7 @@
 from django_q.tasks import async_task
 
 from fyle_integrations_platform_connector import PlatformConnector
+from fyle.platform.exceptions import InvalidTokenError as FyleInvalidTokenError
 
 from apps.workspaces.models import FyleCredential, Workspace, WorkspaceGeneralSettings
 from apps.tasks.models import TaskLog
@@ -197,5 +198,8 @@ def async_create_expense_groups(workspace_id: int, fund_source: List[str], task_
 
 
 def sync_dimensions(fyle_credentials):
-    platform = PlatformConnector(fyle_credentials)
-    platform.import_fyle_dimensions(import_taxes=True)
+    try:
+        platform = PlatformConnector(fyle_credentials)
+        platform.import_fyle_dimensions(import_taxes=True)
+    except FyleInvalidTokenError:
+        logger.info('Invalid Token for fyle')
diff --git a/apps/mappings/tasks.py b/apps/mappings/tasks.py
@@ -1047,6 +1047,8 @@ def auto_create_expense_fields_mappings(
             'Error while creating %s workspace_id - %s in Fyle %s %s',
             fyle_attribute_type, workspace_id, exception.message, {'error': exception.response}
         )
+    except FyleInvalidTokenError:
+        logger.info('Invalid Token for fyle')
     except Exception:
         error = traceback.format_exc()
         error = {

diff --git a/apps/quickbooks_online/utils.py b/apps/quickbooks_online/utils.py
@@ -358,6 +358,10 @@ def post_vendor(self, vendor_name: str, email: str):
         """
         currency = Workspace.objects.get(id=self.workspace_id).fyle_currency
 
+        vendor_name = vendor_name.replace("'", "\\'")  # Replacing ' with \\'
+        vendor_name = vendor_name.replace('#', '%23')  # Replace '#' with %23
+        vendor_name = vendor_name.replace('&', '%26')  # Replace '&' with %26
+
         vendor = {
             'GivenName': vendor_name.split(' ')[0] if email else None,
             'FamilyName': (