Remove settlement from QBD #79

Ashutosh619-sudo · 2024-05-29T16:58:38Z

Summary by CodeRabbit

Bug Fixes
- Removed the settlement_id field from expense entries to streamline data processing.
Dependencies
- Updated fyle-integrations-platform-connector to version 1.37.4 for improved compatibility and performance.

coderabbitai · 2024-05-29T16:58:46Z

Walkthrough

The recent updates primarily involve the removal of the settlement_id field from the Expense model and related test fixtures in the fyle app. Additionally, the fyle-integrations-platform-connector dependency in requirements.txt has been incrementally updated from version 1.36.3 to 1.37.4.

Changes

Files	Change Summary
.../fyle/migrations/0005_remove_expense_settlement_id.py	Removed the `settlement_id` field from the `Expense` model.
.../fyle/models.py	Removed the `settlement_id` field from the `Expense` class and updated the `create_expense_objects` function.
requirements.txt	Updated `fyle-integrations-platform-connector` version from `1.36.3` to `1.37.4`.
.../test_fyle/fixtures.py	Removed `settlement_id` field from multiple dictionaries within the data structures.

Poem

In the code where expenses lie,
Settlement IDs wave goodbye,
Models trimmed, dependencies new,
Tests now fit, sleek and true.
A bunny hops with glee and cheer,
For cleaner code is always near!
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-05-29T17:00:17Z

Tests	Skipped	Failures	Errors	Time
52	0 💤	16 ❌	0 🔥	7.013s ⏱️

ashwin1111 · 2024-05-30T06:26:24Z

@Ashutosh619-sudo pls fix tests and re assign PR

github-actions · 2024-05-31T08:35:52Z

Tests	Skipped	Failures	Errors	Time
4	0 💤	0 ❌	4 🔥	0.792s ⏱️

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 71cb4fb and 66abae1.

Files selected for processing (4)

apps/fyle/migrations/0005_remove_expense_settlement_id.py (1 hunks)
apps/fyle/models.py (2 hunks)
requirements.txt (2 hunks)
tests/test_fyle/fixtures.py (12 hunks)

Files skipped from review due to trivial changes (2)

apps/fyle/migrations/0005_remove_expense_settlement_id.py
requirements.txt

Additional comments not posted (3)

apps/fyle/models.py (2)

Line range hint 34-34: The removal of the settlement_id field aligns with the PR's objective to remove settlement functionality.

Line range hint 90-90: The removal of the settlement_id field from the create_expense_objects function is consistent with the model changes and the PR's objective.

tests/test_fyle/fixtures.py (1)

Line range hint 1-1: Ensure all references to settlement_id are removed in accordance with the PR's objective.

github-actions · 2024-06-03T05:09:05Z

Tests	Skipped	Failures	Errors	Time
4	0 💤	0 ❌	4 🔥	0.799s ⏱️

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 66abae1 and b9f6d7d.

Files selected for processing (1)

requirements.txt (2 hunks)

Files skipped from review as they are similar to previous changes (1)

requirements.txt

github-actions · 2024-06-03T05:19:34Z

Tests	Skipped	Failures	Errors	Time
52	0 💤	0 ❌	0 🔥	7.367s ⏱️

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b9f6d7d and 6276d85.

Files selected for processing (1)

requirements.txt (2 hunks)

Files skipped from review as they are similar to previous changes (1)

requirements.txt

Remove settlement from QBD

0285c7b

Ashutosh619-sudo had a problem deploying to CI Environment May 29, 2024 16:58 — with GitHub Actions Failure

Ashutosh619-sudo requested a review from ashwin1111 May 29, 2024 17:01

ruuushhh approved these changes May 30, 2024

View reviewed changes

ashwin1111 removed their request for review May 30, 2024 06:26

Change integrations-platform-connector version

66abae1

Ashutosh619-sudo had a problem deploying to CI Environment May 31, 2024 08:34 — with GitHub Actions Failure

coderabbitai bot reviewed May 31, 2024

View reviewed changes

change version

b9f6d7d

Ashutosh619-sudo had a problem deploying to CI Environment June 3, 2024 05:07 — with GitHub Actions Failure

coderabbitai bot reviewed Jun 3, 2024

View reviewed changes

change accounting mapping version

6276d85

Ashutosh619-sudo temporarily deployed to CI Environment June 3, 2024 05:17 — with GitHub Actions Inactive

coderabbitai bot reviewed Jun 3, 2024

View reviewed changes

Ashutosh619-sudo merged commit 79cb93b into master Jun 5, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove settlement from QBD #79

Remove settlement from QBD #79

Ashutosh619-sudo commented May 29, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 29, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented May 29, 2024

ashwin1111 commented May 30, 2024

github-actions bot commented May 31, 2024

coderabbitai bot left a comment

github-actions bot commented Jun 3, 2024

coderabbitai bot left a comment

github-actions bot commented Jun 3, 2024

coderabbitai bot left a comment

Remove settlement from QBD #79

Remove settlement from QBD #79

Conversation

Ashutosh619-sudo commented May 29, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented May 29, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented May 29, 2024

ashwin1111 commented May 30, 2024

github-actions bot commented May 31, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 3, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 3, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

Ashutosh619-sudo commented May 29, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 29, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)