QBD CCC Mapping commit #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 99.56% 99.60% +0.04%
==========================================
Files 37 48 +11
Lines 1830 2019 +189
==========================================
+ Hits 1822 2011 +189
Misses 8 8
|
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
requested review from
NileshPant1999
and removed request for
ashwin1111
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
|
@DhaaraniCIT you can fix those lint issues that are coming in codefactor |
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Shwetabhk
reviewed
Sep 5, 2023
apps/mappings/helpers.py
Outdated
| refresh_token=fyle_credentials.refresh_token, | ||
| ) | ||
| query = { | ||
| 'order': 'updated_at.desc', |
There was a problem hiding this comment.
indentations are crt @Shwetabhk , some time in git it shows like this, but the indentations are correct, if it is wrong how it would execute, it will thrown errors
Shwetabhk
reviewed
Sep 5, 2023
apps/mappings/helpers.py
Outdated
| ) | ||
| query = { | ||
| 'order': 'updated_at.desc', | ||
| } |
Shwetabhk
reviewed
Sep 5, 2023
NileshPant1999
approved these changes
Sep 13, 2023
ashwin1111
reviewed
Sep 14, 2023
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
ashwin1111
approved these changes
Sep 14, 2023
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
DhaaraniCIT
had a problem deploying
to
CI Environment
GitHub Actions
Failure
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
DhaaraniCIT
added
deploy
DhaaraniCIT
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Shwetabhk
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.