Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dependent fields get function #80

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Fixing dependent fields get function #80

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3ad916a
Fixing dependent fields get function
Shwetabhk Oct 16, 2023
b628239
Adding param types
Shwetabhk Oct 16, 2023
1001066
Adding separate resource for Dependent Field Values
Shwetabhk Oct 16, 2023
5414603
Renaming class
Shwetabhk Oct 16, 2023
80c8f98
Fixing messaging
Shwetabhk Oct 16, 2023
40ebf0a
Fixing names
Shwetabhk Oct 16, 2023
83c93e7
Changing file name
Shwetabhk Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fyle/platform/apis/v1beta/admin/expense_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@ def __init__(self, version, role):
super().__init__(version, role, ExpenseFields.EXPENSE_FIELDS)


def get_dependent_expense_field_values(self):
def get_dependent_expense_field_values(self, expense_field_id, parent_expense_field_id):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add type

return self.api.make_get_request(
api_url=ExpenseFields.DEPENDENT_EXPENSE_FIELDS_VALUES
api_url=ExpenseFields.DEPENDENT_EXPENSE_FIELDS_VALUES,
query_params={
'expense_field_id': f'eq.{expense_field_id}',
'parent_expense_field_id': f'eq.{parent_expense_field_id}'
}
)

def bulk_post_dependent_expense_field_values(self, payload):
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name='fyle',
version='v0.33.1',
version='v0.34.0',
author='Siva Narayanan',
author_email='[email protected]',
description='Python SDK for accessing Fyle Platform APIs',
Expand Down
Loading