Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revert approver file ids #585

Merged

Conversation

prabs222
Copy link
Contributor

@prabs222 prabs222 commented Dec 6, 2024

Description

Reverting file_ids support from POST approver/expenses PR #552 because this change is not live yet and this restricts other folks from publishing the docs to v1 branch.

Clickup

https://app.clickup.com/1864988/v/l/1rx8w-41176

@prabs222 prabs222 requested a review from KirtiGautam December 6, 2024 04:26
@github-actions github-actions bot added the size/L Large PR label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive)

@prabs222 prabs222 changed the base branch from main to revert-admin_approver-expenses-bulk December 6, 2024 04:27
Copy link

github-actions bot commented Dec 6, 2024

PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive)

@prabs222 prabs222 changed the title Revert approver file ids feat: Revert approver file ids Dec 6, 2024
@prabs222 prabs222 merged commit 9d755b9 into revert-admin_approver-expenses-bulk Dec 6, 2024
3 of 5 checks passed
prabs222 added a commit that referenced this pull request Dec 6, 2024
* feat: revert 554 POST /<admin/approver>/expenses/bulk

* feat: revert approver file_ids support from 552 POST /approver/expenses (#585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants