Per diem documentation #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/schemas/fields.yaml
Outdated
| @@ -239,6 +239,7 @@ spent_at: | |||
| description: | | |||
| It signifies when this expense was made. | |||
| This date cannot be in future. | |||
| This field is not required for creating Per Diem Expenses | |||
There was a problem hiding this comment.
changing this description here, will show it in each and every API, that is using spent_at, even CCC, Please check it out once, if yes, we'll have to somehow add the description only for expenses API spent_at.
muleyashutosh
approved these changes
Oct 19, 2023
KirtiGautam
reviewed
Oct 25, 2023
src/components/schemas/expense.yaml
Outdated
| example: 583 | ||
| description: | | ||
| Specific to per diem expense. This represents the per diem's rate id given by Fyle | ||
| during creation of per diem rate for which this expense is created. |
There was a problem hiding this comment.
Please add note that this is required in case of per diem category.
| description: | | ||
| Date on which the expense was made. | ||
| This date cannot be in future. | ||
| This field is not required for creating Per Diem Expenses |
There was a problem hiding this comment.
Can we talk about how per diems are created/most probably in the header?
src/components/schemas/expense.yaml
Outdated
| nullable: true | ||
| example: 2 | ||
| description: | | ||
| Specific to per diem related expenses, number of days for which per diem claim is made. |
There was a problem hiding this comment.
Add note that this is required for per diems
KirtiGautam
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/8678zba8b