Feat: Version bump for fyle-accounting-mapping fields #690
Conversation
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
WalkthroughThe pull request includes an update to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (4)tests/sql_fixtures/reset_db_fixtures/reset_db.sql (4)
The migration entry follows Django conventions and maintains the correct sequence order.
The sequence value has been properly incremented to match the new migration ID.
The addition of audit trail columns Let's check if other audit-related columns in the schema have NOT NULL constraints:
The COPY command has been properly updated to include the new audit columns. The use of Let's verify the column count matches across all data rows: ✅ Verification successfulLet me gather more information to understand the table structure and expected column count. Data consistency issue detected in COPY statements The verification revealed varying field counts across data rows, but this appears to be normal as the COPY statements belong to different tables with varying column counts. Looking at the COPY commands and their corresponding data:
Each table's COPY command properly matches its data structure, and the 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Count fields in each COPY data row to ensure consistency
rg "^[0-9].*\\t.*\\t.*\\\\N.*\\\\N$" tests/sql_fixtures/reset_db_fixtures/reset_db.sql | awk -F'\t' '{print NF}' | sort | uniq -c
Length of output: 191 Script: #!/bin/bash
# Find the COPY command and its table name
rg "^COPY.*FROM stdin;" tests/sql_fixtures/reset_db_fixtures/reset_db.sql -B2 | grep "COPY"
# Get a sample of rows with different field counts
echo "=== Sample row with 10 fields ==="
rg "^[0-9].*\\t.*\\t.*\\\\N.*\\\\N$" tests/sql_fixtures/reset_db_fixtures/reset_db.sql | awk -F'\t' 'NF==10 {print; exit}'
echo "=== Sample row with 12 fields ==="
rg "^[0-9].*\\t.*\\t.*\\\\N.*\\\\N$" tests/sql_fixtures/reset_db_fixtures/reset_db.sql | awk -F'\t' 'NF==12 {print; exit}'
echo "=== Sample row with 14 fields ==="
rg "^[0-9].*\\t.*\\t.*\\\\N.*\\\\N$" tests/sql_fixtures/reset_db_fixtures/reset_db.sql | awk -F'\t' 'NF==14 {print; exit}'
Length of output: 10946 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Description
Please add PR description here, add screenshots if needed
Clickup
Please add link here
https://app.clickup.com/1864988/v/l/6-901605343641-1
Summary by CodeRabbit
fyle-accounting-mappingspackage to 1.36.2.mapping_settingstable by addingcreated_byandupdated_bycolumns for user tracking.mapping_settingstable.