fix: include receipt links in all line items for cc charges

[JustARatherRidiculouslyLongUsername]

Clickup

https://app.clickup.com/t/86cx4hyg6

Summary by CodeRabbit

• New Features

  • Enhanced handling of attachments for credit card charges to ensure all expenses in a group have their attachments processed and uploaded.

• Bug Fixes

  • Improved error handling for attachment uploads, ensuring proper logging and failure marking for invalid tokens and other exceptions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on the create_credit_card_charge function within the apps/netsuite/tasks.py file. The primary modification involves updating the logic to handle attachments for all expenses in a credit card charge, rather than just the first expense. The function now iterates through each expense, ensuring that all relevant attachments are processed and uploaded. Additionally, the conditional check for successful attachment retrieval has been moved inside the loop to enhance robustness, while error handling mechanisms remain unchanged.

Changes

File Path	Change Summary
apps/netsuite/tasks.py	Modified create_credit_card_charge to process attachments for all expenses instead of just the first one. Adjusted the conditional check for attachment links to occur within the loop. Error handling remains consistent.

Possibly related PRs

• feat: Add Receipt URL #645: This PR adds a new field is_attachment_upload_failed to the CreditCardCharge model, which is relevant to the changes in the create_credit_card_charge function that now handles attachments for all expenses.
• fix: handle post acconting summary #646: This PR modifies the create_credit_card_charge function, which is directly related to the changes made in the main PR regarding attachment handling.
• test: write unit tests and add fixtures for split expense grouping #670: This PR updates the test for the load_attachments function to include a credit_card_charge_object, which is relevant to the changes made in the main PR regarding attachment processing for credit card charges.

Suggested labels

size/M

Suggested reviewers

• ruuushhh

🐇 In the meadow where bunnies play,
Attachments now come out to stay.
Each expense, a link to find,
No more left behind, oh so kind!
With every charge, we hop and cheer,
Robust uploads, let’s make it clear!
🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Tests	Skipped	Failures	Errors	Time
232	0 💤	0 ❌	0 🔥	25.869s ⏱️