Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync import API #459

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Sync import API #459

merged 3 commits into from
Nov 29, 2023

Conversation

Ashutosh619-sudo
Copy link
Contributor

No description provided.

Copy link

Tests Skipped Failures Errors Time
210 0 💤 0 ❌ 0 🔥 22.602s ⏱️

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #459 (4f93375) into expense_serializer (8b0760f) will decrease coverage by 0.06%.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           expense_serializer     #459      +/-   ##
======================================================
- Coverage               94.97%   94.91%   -0.06%     
======================================================
  Files                      47       47              
  Lines                    4613     4621       +8     
======================================================
+ Hits                     4381     4386       +5     
- Misses                    232      235       +3     
Files Coverage Δ
apps/fyle/tasks.py 100.00% <100.00%> (ø)
apps/fyle/views.py 88.13% <50.00%> (-1.40%) ⬇️

@@ -419,3 +419,20 @@ def get(self, request, *args, **kwargs):
},
status=status.HTTP_400_BAD_REQUEST
)


class ExpenseGroupSyncView(generics.CreateAPIView):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the the corresponding url path in url file ??

Copy link

Tests Skipped Failures Errors Time
210 0 💤 0 ❌ 0 🔥 20.874s ⏱️

@Ashutosh619-sudo Ashutosh619-sudo merged commit d429e9c into expense_serializer Nov 29, 2023
1 of 3 checks passed
Ashutosh619-sudo added a commit that referenced this pull request Nov 29, 2023
* added more fields in expense serializer

* Sync import API (#459)

* added expense group sync API

* minor changes

* added url for expense group sync view
Ashutosh619-sudo added a commit that referenced this pull request Nov 29, 2023
* add employee name in expense and script to populate data

* test fixture changes

* added field export_url in expense group and util to generate URL

* updated test and fixtures

* changed scripts to batch update export url

* bug fix

* comment resolved

* added more fields in expense serializer for redirection (#458)

* added more fields in expense serializer

* Sync import API (#459)

* added expense group sync API

* minor changes

* added url for expense group sync view
Ashutosh619-sudo added a commit that referenced this pull request Nov 29, 2023
* employee email added to expense group

* added field export_url in expense group and util to generate URL (#457)

* add employee name in expense and script to populate data

* test fixture changes

* added field export_url in expense group and util to generate URL

* updated test and fixtures

* changed scripts to batch update export url

* bug fix

* comment resolved

* added more fields in expense serializer for redirection (#458)

* added more fields in expense serializer

* Sync import API (#459)

* added expense group sync API

* minor changes

* added url for expense group sync view

* remove redundant script
Ashutosh619-sudo added a commit that referenced this pull request Nov 29, 2023
…PI (#454)

* exportable expense API and date range filter for expense group view  API

* test added

* filter for date range

* comment resolved

* comment resolved

* employee email added to expense group (#463)

* employee email added to expense group

* added field export_url in expense group and util to generate URL (#457)

* add employee name in expense and script to populate data

* test fixture changes

* added field export_url in expense group and util to generate URL

* updated test and fixtures

* changed scripts to batch update export url

* bug fix

* comment resolved

* added more fields in expense serializer for redirection (#458)

* added more fields in expense serializer

* Sync import API (#459)

* added expense group sync API

* minor changes

* added url for expense group sync view

* remove redundant script

* added upload_attachments and update exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants