-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync import API #459
Merged
Merged
Sync import API #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
November 23, 2023 11:11 — with
GitHub Actions
Inactive
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## expense_serializer #459 +/- ##
======================================================
- Coverage 94.97% 94.91% -0.06%
======================================================
Files 47 47
Lines 4613 4621 +8
======================================================
+ Hits 4381 4386 +5
- Misses 232 235 +3
|
@@ -419,3 +419,20 @@ def get(self, request, *args, **kwargs): | |||
}, | |||
status=status.HTTP_400_BAD_REQUEST | |||
) | |||
|
|||
|
|||
class ExpenseGroupSyncView(generics.CreateAPIView): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the the corresponding url path in url file ??
Ashutosh619-sudo
temporarily deployed
to
CI Environment
November 27, 2023 11:10 — with
GitHub Actions
Inactive
|
ashwin1111
approved these changes
Nov 29, 2023
Ashutosh619-sudo
added a commit
that referenced
this pull request
Nov 29, 2023
* added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view
Ashutosh619-sudo
added a commit
that referenced
this pull request
Nov 29, 2023
* add employee name in expense and script to populate data * test fixture changes * added field export_url in expense group and util to generate URL * updated test and fixtures * changed scripts to batch update export url * bug fix * comment resolved * added more fields in expense serializer for redirection (#458) * added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view
Ashutosh619-sudo
added a commit
that referenced
this pull request
Nov 29, 2023
* employee email added to expense group * added field export_url in expense group and util to generate URL (#457) * add employee name in expense and script to populate data * test fixture changes * added field export_url in expense group and util to generate URL * updated test and fixtures * changed scripts to batch update export url * bug fix * comment resolved * added more fields in expense serializer for redirection (#458) * added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view * remove redundant script
Ashutosh619-sudo
added a commit
that referenced
this pull request
Nov 29, 2023
…PI (#454) * exportable expense API and date range filter for expense group view API * test added * filter for date range * comment resolved * comment resolved * employee email added to expense group (#463) * employee email added to expense group * added field export_url in expense group and util to generate URL (#457) * add employee name in expense and script to populate data * test fixture changes * added field export_url in expense group and util to generate URL * updated test and fixtures * changed scripts to batch update export url * bug fix * comment resolved * added more fields in expense serializer for redirection (#458) * added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view * remove redundant script * added upload_attachments and update exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.