added field export_url in expense group and util to generate URL #457

Ashutosh619-sudo · 2023-11-22T11:30:22Z

No description provided.

github-actions · 2023-11-22T11:32:43Z

Tests	Skipped	Failures	Errors	Time
210	0 💤	63 ❌	15 🔥	35.080s ⏱️

github-actions · 2023-11-22T16:08:21Z

Tests	Skipped	Failures	Errors	Time
210	0 💤	0 ❌	0 🔥	19.977s ⏱️

codecov · 2023-11-22T16:09:09Z

Codecov Report

Merging #457 (4cd1765) into employee_in_expense_new (64f108a) will decrease coverage by 0.05%.
The diff coverage is 86.95%.

Additional details and impacted files

@@                     Coverage Diff                     @@
##           employee_in_expense_new     #457      +/-   ##
===========================================================
- Coverage                    95.09%   95.04%   -0.05%     
===========================================================
  Files                           49       49              
  Lines                         4665     4679      +14     
===========================================================
+ Hits                          4436     4447      +11     
- Misses                         229      232       +3

Files	Coverage Δ
apps/fyle/models.py	`97.34% <100.00%> (+0.02%)`	⬆️
apps/fyle/serializers.py	`100.00% <100.00%> (ø)`
apps/fyle/tasks.py	`100.00% <100.00%> (ø)`
apps/netsuite/tasks.py	`95.10% <100.00%> (+0.01%)`	⬆️
apps/fyle/views.py	`87.79% <50.00%> (-1.44%)`	⬇️

NileshPant1999 · 2023-11-27T11:04:51Z

scripts/python/update-export-url.py

+        url = generate_netsuite_export_url(response_logs=expense_group.response_logs, ns_account_id=netsuite_cred.ns_account_id)
+        expense_group.export_url = url
+        expense_group.save()
+        print('Export URl updated for expense group id {}'.format(expense_group.id))


remove loggers

NileshPant1999 · 2023-11-27T11:05:13Z

scripts/python/update-export-url.py

+        expense_group.save()
+        print('Export URl updated for expense group id {}'.format(expense_group.id))
+    except Exception as exception:
+        print('Something went wrong during updating export_url for workspace_id {}'.format(expense_group.workspace_id))


add valid exceptions here

ashwin1111 · 2023-11-27T11:03:23Z

apps/netsuite/tasks.py

@@ -71,6 +72,13 @@
 }


+def add_export_url(response_logs, ns_account_id, expense_group):


generate_export_url

actually, remove this whole func, call generate_netsuite_export_url directly

ashwin1111 · 2023-11-27T11:03:35Z

apps/netsuite/tasks.py

+def add_export_url(response_logs, ns_account_id, expense_group):
+    try:
+        url = generate_netsuite_export_url(response_logs, ns_account_id)
+        expense_group.export_url = url


return url from this func and assign value there

ashwin1111 · 2023-11-27T11:03:58Z

fyle_netsuite_api/utils.py

@@ -23,3 +23,22 @@ def filter_queryset(self, queryset):
            filter_kwargs = {self.lookup_field: lookup_value}
            queryset = queryset.filter(**filter_kwargs)
        return super().filter_queryset(queryset)
+
+
+export_type_redirection = {


declare const at top, all caps variable.

ashwin1111 · 2023-11-27T11:11:11Z

scripts/python/update-export-url.py

+
+expense_groups = ExpenseGroup.objects.all()
+
+for expense_group in expense_groups:


let's iterate through workspaces (prod only - exclude workspaces that has name like test / fyle / sandbox). Iterate through workspace and filter expense groups that has response logs != null and do it in batches. https://github.com/fylein/fyle-integration-scripts/blob/master/qbo/batched-fill.py check this out on how to do it in batches

github-actions · 2023-11-27T17:27:52Z

Tests	Skipped	Failures	Errors	Time
210	0 💤	4 ❌	4 🔥	21.236s ⏱️

github-actions · 2023-11-28T20:47:24Z

Tests	Skipped	Failures	Errors	Time
210	0 💤	0 ❌	0 🔥	21.689s ⏱️

ashwin1111 · 2023-11-29T08:58:57Z

fyle_netsuite_api/utils.py

+            url = f'https://{ns_account_id}.app.netsuite.com/app/accounting/transactions/${redirection}.nl?id={internal_id}'
+            return url
+        except Exception as exception:
+            logger.info({'error': exception})


logger.exception

ashwin1111 · 2023-11-29T08:59:22Z

scripts/python/update-export-url.py

+from fyle_netsuite_api.utils import generate_netsuite_export_url
+
+
+folder_created_workspace_ids = []


ashwin1111 · 2023-11-29T08:59:27Z

scripts/python/update-export-url.py

+
+prod_workspaces = Workspace.objects.exclude(
+    name__iregex=r'(fyle|test)',
+    id__in=folder_created_workspace_ids


github-actions · 2023-11-29T09:44:33Z

Tests	Skipped	Failures	Errors	Time
210	0 💤	0 ❌	0 🔥	20.467s ⏱️

* added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view

github-actions · 2023-11-29T12:37:50Z

Tests	Skipped	Failures	Errors	Time
216	0 💤	0 ❌	0 🔥	20.788s ⏱️

* employee email added to expense group * added field export_url in expense group and util to generate URL (#457) * add employee name in expense and script to populate data * test fixture changes * added field export_url in expense group and util to generate URL * updated test and fixtures * changed scripts to batch update export url * bug fix * comment resolved * added more fields in expense serializer for redirection (#458) * added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view * remove redundant script

…PI (#454) * exportable expense API and date range filter for expense group view API * test added * filter for date range * comment resolved * comment resolved * employee email added to expense group (#463) * employee email added to expense group * added field export_url in expense group and util to generate URL (#457) * add employee name in expense and script to populate data * test fixture changes * added field export_url in expense group and util to generate URL * updated test and fixtures * changed scripts to batch update export url * bug fix * comment resolved * added more fields in expense serializer for redirection (#458) * added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view * remove redundant script * added upload_attachments and update exports

Ashutosh619-sudo added 3 commits November 20, 2023 16:45

add employee name in expense and script to populate data

96c7dc6

test fixture changes

3a7f7f2

added field export_url in expense group and util to generate URL

28fc1e3

Ashutosh619-sudo had a problem deploying to CI Environment November 22, 2023 11:30 — with GitHub Actions Failure

updated test and fixtures

535c619

Ashutosh619-sudo temporarily deployed to CI Environment November 22, 2023 16:06 — with GitHub Actions Inactive

Ashutosh619-sudo requested a review from NileshPant1999 November 23, 2023 09:35

NileshPant1999 reviewed Nov 27, 2023

View reviewed changes

ashwin1111 reviewed Nov 27, 2023

View reviewed changes

changed scripts to batch update export url

0db7d94

Ashutosh619-sudo had a problem deploying to CI Environment November 27, 2023 17:25 — with GitHub Actions Failure

bug fix

076f9d2

Ashutosh619-sudo temporarily deployed to CI Environment November 28, 2023 20:45 — with GitHub Actions Inactive

Ashutosh619-sudo requested a review from ashwin1111 November 29, 2023 08:20

ashwin1111 approved these changes Nov 29, 2023

View reviewed changes

comment resolved

9b0998e

Ashutosh619-sudo temporarily deployed to CI Environment November 29, 2023 09:42 — with GitHub Actions Inactive

Ashutosh619-sudo changed the base branch from employee_in_expense to employee_in_expense_new November 29, 2023 11:14

Ashutosh619-sudo changed the base branch from employee_in_expense_new to employee_in_expense November 29, 2023 11:27

Ashutosh619-sudo changed the base branch from employee_in_expense to employee_in_expense_new November 29, 2023 11:48

Ashutosh619-sudo and others added 2 commits November 29, 2023 03:52

added more fields in expense serializer for redirection (#458)

cf736f5

* added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view

Merge branch 'employee_in_expense_new' into export_url_field

4cd1765

Ashutosh619-sudo temporarily deployed to CI Environment November 29, 2023 12:35 — with GitHub Actions Inactive

Ashutosh619-sudo merged commit 36dd0f9 into employee_in_expense_new Nov 29, 2023
1 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added field export_url in expense group and util to generate URL #457

added field export_url in expense group and util to generate URL #457

Ashutosh619-sudo commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

codecov bot commented Nov 22, 2023 •

edited

Loading

NileshPant1999 Nov 27, 2023

NileshPant1999 Nov 27, 2023

ashwin1111 Nov 27, 2023

ashwin1111 Nov 27, 2023

ashwin1111 Nov 27, 2023

ashwin1111 Nov 27, 2023

ashwin1111 Nov 27, 2023

github-actions bot commented Nov 27, 2023

github-actions bot commented Nov 28, 2023

ashwin1111 Nov 29, 2023

ashwin1111 Nov 29, 2023

ashwin1111 Nov 29, 2023

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

		@@ -71,6 +72,13 @@
		}


		def add_export_url(response_logs, ns_account_id, expense_group):


		expense_groups = ExpenseGroup.objects.all()

		for expense_group in expense_groups:

		from fyle_netsuite_api.utils import generate_netsuite_export_url


		folder_created_workspace_ids = []

added field export_url in expense group and util to generate URL #457

added field export_url in expense group and util to generate URL #457

Conversation

Ashutosh619-sudo commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 22, 2023

codecov bot commented Nov 22, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2023

github-actions bot commented Nov 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

codecov bot commented Nov 22, 2023 •

edited

Loading