exportable expense API and date range filter for expense group view API #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 95.12% 95.04% -0.09%
==========================================
Files 49 49
Lines 4636 4682 +46
==========================================
+ Hits 4410 4450 +40
- Misses 226 232 +6
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
apps/fyle/views.py
Outdated
| workspace_id=self.kwargs['workspace_id'], | ||
| exported_at__isnull=True, | ||
| fund_source__in=fund_source | ||
| ).values_list('id', flat=True) |
There was a problem hiding this comment.
can move all of the above code to a helper function and get ids from there
can help make the view look a bit cleaner
tests/test_fyle/test_views.py
Outdated
| assert response.status_code==200 | ||
|
|
||
| response = json.loads(response.content) | ||
| assert response['exportable_expense_group_ids'] == [1, 2] |
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
approved these changes
Nov 29, 2023
apps/fyle/actions.py
Outdated
| from apps.workspaces.models import Configuration | ||
|
|
||
|
|
||
| def get_expense_group_ids(workspace_id, ): |
There was a problem hiding this comment.
action file should do some sort of updates. This seem more like a helper func, move it to helpers.py
There was a problem hiding this comment.
remove extra comma in arg
There was a problem hiding this comment.
name it get_exportable_expense_group_ids()
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
* employee email added to expense group * added field export_url in expense group and util to generate URL (#457) * add employee name in expense and script to populate data * test fixture changes * added field export_url in expense group and util to generate URL * updated test and fixtures * changed scripts to batch update export url * bug fix * comment resolved * added more fields in expense serializer for redirection (#458) * added more fields in expense serializer * Sync import API (#459) * added expense group sync API * minor changes * added url for expense group sync view * remove redundant script
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.