Setting and Resolving Netsuite Error #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## tax_mapping_err #448 +/- ##
===================================================
- Coverage 95.32% 95.28% -0.04%
===================================================
Files 48 48
Lines 4530 4543 +13
===================================================
+ Hits 4318 4329 +11
- Misses 212 214 +2
|
apps/netsuite/exceptions.py
Outdated
|
|
||
| Error.objects.update_or_create( | ||
| workspace_id=expense_group.workspace_id, | ||
| expense_group=expense_group, |
There was a problem hiding this comment.
spacing is not correct
NileshPant1999
approved these changes
Nov 15, 2023
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
added a commit
that referenced
this pull request
Nov 27, 2023
* Setting tax mapping and resolve * resolved comments * Setting and Resolving Netsuite Error (#448) * Setting Netsuite Error * resolving netsuite error * setting netsuite error resolved * comment resolved --------- Co-authored-by: Ashutosh619-sudo <[email protected]> --------- Co-authored-by: Ashutosh619-sudo <[email protected]>
Ashutosh619-sudo
added a commit
that referenced
this pull request
Nov 27, 2023
* category mapping error settings and resolution * test added * Setting tax mapping and resolve (#447) * Setting tax mapping and resolve * resolved comments * Setting and Resolving Netsuite Error (#448) * Setting Netsuite Error * resolving netsuite error * setting netsuite error resolved * comment resolved --------- Co-authored-by: Ashutosh619-sudo <[email protected]> --------- Co-authored-by: Ashutosh619-sudo <[email protected]> --------- Co-authored-by: Ashutosh619-sudo <[email protected]>
Ashutosh619-sudo
added a commit
that referenced
this pull request
Nov 27, 2023
…tor (#445) * onboarding state implementation * tests migrations * added onboarding state * changed comment * added subsidiary state to onboarding state * changed script to add subsidiary state and fixed some bug * bug fix * state change on connection and subsidiary change * map employees v2 api * map_employees typos * bug fix * export setting changes * export settings V2 api * added test for export settings api * resolved comments * import settings v2 api * test added for import settings v2 api * advanced settings v2 api * advanced settings v2 api with test case * First schedule should be triggered after interval hours * Handle Admin GET in a safer way * Making reimbursbale expense object nullable and checking edge cases for the same * comment resolved * resolving comments * all comment resolved * added code in test for the changes * added test code for the changes * Error model, API and test * Export error decorator, creating employee error and resolving. * exception error removed * import error resolved * employee mapping error test added * made changes to the decorator for export functions * Settings category mapping error and resolving (#446) * category mapping error settings and resolution * test added * Setting tax mapping and resolve (#447) * Setting tax mapping and resolve * resolved comments * Setting and Resolving Netsuite Error (#448) * Setting Netsuite Error * resolving netsuite error * setting netsuite error resolved * comment resolved --------- Co-authored-by: Ashutosh619-sudo <[email protected]> --------- Co-authored-by: Ashutosh619-sudo <[email protected]> --------- Co-authored-by: Ashutosh619-sudo <[email protected]> * resolved comments * resolved comments --------- Co-authored-by: Ashutosh619-sudo <[email protected]> Co-authored-by: Nilesh Pant <[email protected]> Co-authored-by: Nilesh Pant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.