Setting Employee Mapping error, resolving and export exception decorator #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 94.99% 95.14% +0.15%
==========================================
Files 47 49 +2
Lines 4574 4633 +59
==========================================
+ Hits 4345 4408 +63
+ Misses 229 225 -4
|
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
NileshPant1999
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
|
ashwin1111
reviewed
Nov 27, 2023
apps/netsuite/exceptions.py
Outdated
| logger.exception('Something unexpected happened workspace_id: %s %s', task_log.workspace_id, task_log.detail) | ||
|
|
||
|
|
||
| def update_last_export_details(workspace_id): |
There was a problem hiding this comment.
this should be present in actions.py
apps/netsuite/exceptions.py
Outdated
Comment on lines
70
to
76
| workspace_id=workspace_id, | ||
| task_id='PAYMENT_{}'.format(entity_object['unique_id']), | ||
| defaults={ | ||
| 'status': 'IN_PROGRESS', | ||
| 'type': 'CREATING_VENDOR_PAYMENT' | ||
| } | ||
| ) |
apps/netsuite/exceptions.py
Outdated
Comment on lines
87
to
98
| if payment: | ||
| logger.info( | ||
| 'NetSuite Credentials not found for workspace_id %s', | ||
| workspace_id | ||
| ) | ||
| detail = { | ||
| 'message': 'NetSuite Account not connected' | ||
| } | ||
| task_log.status = 'FAILED' | ||
| task_log.detail = detail | ||
|
|
||
| task_log.save() |
There was a problem hiding this comment.
why special treatment for payment?
There was a problem hiding this comment.
in the payment function there is no expense_group
There was a problem hiding this comment.
also the Error Model needs expense_group
There was a problem hiding this comment.
can assign expense_group = None inside 55 line block and then in __handle_netsuite_connection_error(), check for expense_group existence and update or create things
apps/netsuite/exceptions.py
Outdated
Comment on lines
114
to
115
| if not payment: | ||
| all_details[0]['expense_group_id'] = expense_group.id |
There was a problem hiding this comment.
this info isn't needed, can remove it off
apps/netsuite/exceptions.py
Outdated
| expense_group.workspace_id | ||
| ) | ||
| detail = { | ||
| 'expense_group_id': expense_group.id, |
There was a problem hiding this comment.
this is not needed, can treat payment and exports same
* category mapping error settings and resolution * test added * Setting tax mapping and resolve (#447) * Setting tax mapping and resolve * resolved comments * Setting and Resolving Netsuite Error (#448) * Setting Netsuite Error * resolving netsuite error * setting netsuite error resolved * comment resolved --------- Co-authored-by: Ashutosh619-sudo <[email protected]> --------- Co-authored-by: Ashutosh619-sudo <[email protected]> --------- Co-authored-by: Ashutosh619-sudo <[email protected]>
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
approved these changes
Nov 27, 2023
apps/netsuite/exceptions.py
Outdated
Comment on lines
87
to
98
| if payment: | ||
| logger.info( | ||
| 'NetSuite Credentials not found for workspace_id %s', | ||
| workspace_id | ||
| ) | ||
| detail = { | ||
| 'message': 'NetSuite Account not connected' | ||
| } | ||
| task_log.status = 'FAILED' | ||
| task_log.detail = detail | ||
|
|
||
| task_log.save() |
There was a problem hiding this comment.
can assign expense_group = None inside 55 line block and then in __handle_netsuite_connection_error(), check for expense_group existence and update or create things
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.