V2 Export setting api #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 95.17% 95.22% +0.05%
==========================================
Files 37 39 +2
Lines 4186 4274 +88
==========================================
+ Hits 3984 4070 +86
- Misses 202 204 +2
|
added 2 commits
October 25, 2023 17:01
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
| return { | ||
| 'id': instance.reimbursable_account_id, | ||
| 'name': instance.reimbursable_account_name | ||
| } |
There was a problem hiding this comment.
can we add linespaces between each function
NileshPant1999
approved these changes
Oct 25, 2023
ashwin1111
reviewed
Oct 26, 2023
| 'corporate_credit_card_expenses_object', | ||
| 'is_simplify_report_closure_enabled', | ||
| 'auto_map_employees', | ||
| 'employee_field_mapping' |
There was a problem hiding this comment.
this is already a part of map_employees, not needed here
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.