V2 map employees api #430
Merged
V2 map employees api #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 95.60% 95.17% -0.43%
==========================================
Files 34 37 +3
Lines 4138 4186 +48
==========================================
+ Hits 3956 3984 +28
- Misses 182 202 +20
|
ashwin1111
reviewed
Oct 20, 2023
Comment on lines
32
to
34
| if configuration and (configuration_instance.employee_field_mapping != configuration['employee_field_mapping']): | ||
| configuration_instance.reimbursable_expenses_object = None | ||
| configuration_instance.save() |
There was a problem hiding this comment.
why is this block required?
| workspace_id=workspace_id, defaults={'employee_field_mapping': configuration['employee_field_mapping'], 'auto_map_employees': configuration['auto_map_employees']} | ||
| ) | ||
|
|
||
| MapEmplyeesTriggers.run_workspace_general_settings_triggers(configuration=configuration_instance) |
There was a problem hiding this comment.
run_configurations_triggers
| from apps.workspaces.models import Configuration | ||
|
|
||
|
|
||
| class MapEmplyeesTriggers: |
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
ashwin1111
approved these changes
Oct 20, 2023
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.