Update direct export URLs (#584)

* Update direct export URLs * Fix tests
fylein · Jun 11, 2024 · e804566 · e804566
1 parent e36cda6
commit e804566
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/apps/fyle/actions.py b/apps/fyle/actions.py
@@ -19,10 +19,10 @@
 
 def __get_redirection_url(workspace_id: str, state: str) -> str:
     map = {
-        'IN_PROGRESS': '{}/workspaces/{}/dashboard',
-        'ERROR': '{}/workspaces/{}/expense_groups?page_number=0&page_size=10&state=FAILED',
-        'SKIPPED': '{}/workspaces/{}/expense_groups?page_number=0&page_size=10&state=SKIP',
-        'DELETED': '{}/workspaces/{}/dashboard'
+        'IN_PROGRESS': '{}/main/dashboard',
+        'ERROR': '{}/main/dashboard',
+        'SKIPPED': '{}/main/export_log',
+        'DELETED': '{}/main/dashboard'
     }
     if settings.BRAND_ID == 'fyle':
         return map[state].format(settings.NETSUITE_INTEGRATION_APP_URL, workspace_id)

diff --git a/scripts/sql/scripts/024-fill-skipped-accounting-export-summary.sql b/scripts/sql/scripts/024-fill-skipped-accounting-export-summary.sql
@@ -3,7 +3,7 @@ begin;
 
 update expenses set accounting_export_summary = jsonb_build_object(
     'id', expense_id,
-    'url', CONCAT('https://netsuite.fyleapps.com/workspaces/', workspace_id, '/expense_groups?page_number=0&page_size=10&state=SKIP'),
+    'url', CONCAT('https://app.fylehq.com/app/settings/#/integrations/native_apps?integrationIframeTarget=integrations/netsuite/main/export_log'),
     'state', 'SKIPPED',
     'synced', false,
     'error_type', null

diff --git a/tests/test_fyle/test_actions.py b/tests/test_fyle/test_actions.py
@@ -28,7 +28,7 @@ def test_update_expenses_in_progress(db):
     for expense in expenses:
         assert expense.accounting_export_summary['synced'] == False
         assert expense.accounting_export_summary['state'] == 'IN_PROGRESS'
-        assert expense.accounting_export_summary['url'] == '{}/workspaces/{}/dashboard'.format(settings.NETSUITE_INTEGRATION_APP_URL, expense.workspace_id)
+        assert expense.accounting_export_summary['url'] == '{}/main/dashboard'.format(settings.NETSUITE_INTEGRATION_APP_URL)
         assert expense.accounting_export_summary['error_type'] == None
         assert expense.accounting_export_summary['id'] == expense.expense_id
 
@@ -42,7 +42,7 @@ def test_update_failed_expenses(db):
         assert expense.accounting_export_summary['synced'] == False
         assert expense.accounting_export_summary['state'] == 'ERROR'
         assert expense.accounting_export_summary['error_type'] == 'MAPPING'
-        assert expense.accounting_export_summary['url'] == '{}/workspaces/{}/expense_groups?page_number=0&page_size=10&state=FAILED'.format(settings.NETSUITE_INTEGRATION_APP_URL, expense.workspace_id)
+        assert expense.accounting_export_summary['url'] == '{}/main/dashboard'.format(settings.NETSUITE_INTEGRATION_APP_URL)
         assert expense.accounting_export_summary['id'] == expense.expense_id
 
 def test_update_complete_expenses(db):
@@ -118,7 +118,7 @@ def test_handle_post_accounting_export_summary_exception(db):
     assert expense.accounting_export_summary['synced'] == True
     assert expense.accounting_export_summary['state'] == 'DELETED'
     assert expense.accounting_export_summary['error_type'] == None
-    assert expense.accounting_export_summary['url'] == '{}/workspaces/{}/dashboard'.format(settings.NETSUITE_INTEGRATION_APP_URL, expense.workspace_id)
+    assert expense.accounting_export_summary['url'] == '{}/main/dashboard'.format(settings.NETSUITE_INTEGRATION_APP_URL)
     assert expense.accounting_export_summary['id'] == expense_id