Skip to content

Commit

Permalink
fix: fix export url generation for sandbox accounts (#659)
Browse files Browse the repository at this point in the history
* fix: fix export url generation for sandbox accounts

* fix: add script to update bad db data
  • Loading branch information
1 parent 054b3c1 commit b353f2f
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fyle_netsuite_api/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ def generate_netsuite_export_url(response_logs : OrderedDict, netsuite_credentia
if response_logs:
try:
ns_account_id = netsuite_credentials.ns_account_id.lower()
if '_sb' in ns_account_id:
ns_account_id = ns_account_id.replace('_sb', '-sb')

export_type = response_logs['type'] if 'type' in response_logs and response_logs['type'] else 'chargeCard'
internal_id = response_logs['internalId']
redirection = EXPORT_TYPE_REDIRECTION[export_type]
Expand Down
17 changes: 17 additions & 0 deletions scripts/sql/scripts/029-update-sandbox-export-urls.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
rollback;
begin;

-- These values should be swapped after running the script
-- netsuite=> select count(export_url) from expense_groups where export_url like '%_sb%';
-- count
-- -------
-- 240
-- (1 row)

-- netsuite=> select count(export_url) from expense_groups where export_url like '%-sb%';
-- count
-- -------
-- 0
-- (1 row)

update expense_groups set export_url = replace(export_url, '_sb', '-sb');

0 comments on commit b353f2f

Please sign in to comment.