Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: After testing #35

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Bug Fix: After testing #35

merged 14 commits into from
Nov 30, 2023

Conversation

ruuushhh
Copy link
Contributor

No description provided.

Copy link

Tests Skipped Failures Errors Time
21 0 💤 8 ❌ 0 🔥 4.027s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 8 ❌ 0 🔥 4.701s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.358s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 1 ❌ 0 🔥 2.498s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 1 ❌ 0 🔥 2.442s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.414s ⏱️

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8791ea6) 86.04% compared to head (cea3b0b) 87.24%.
Report is 1 commits behind head on fyle_orgs_api.

Files Patch % Lines
apps/accounting_exports/models.py 95.23% 2 Missing ⚠️
apps/workspaces/helpers.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           fyle_orgs_api      #35      +/-   ##
=================================================
+ Coverage          86.04%   87.24%   +1.20%     
=================================================
  Files                 30       30              
  Lines               1261     1333      +72     
=================================================
+ Hits                1085     1163      +78     
+ Misses               176      170       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.100s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 13 🔥 2.964s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.410s ⏱️

Copy link

coderabbitai bot commented Nov 29, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.353s ⏱️

@ruuushhh ruuushhh changed the base branch from get_user_profile_api to fyle_orgs_api November 29, 2023 14:55
Copy link

Tests Skipped Failures Errors Time
21 0 💤 1 ❌ 0 🔥 2.129s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.345s ⏱️

Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.232s ⏱️

* Imports Folder Structure

* Import base files added (#39)

* Import base files added

* Import Categories support added (#40)

* Import Categories support added

* Import merchants support added (#41)

* Import merchants support added

* Import cost centers support added (#42)

* Import cost centers support added

* Import project support added (#43)

* Import project support added

* Schedule, queues signals configured (#44)

* Schedule, queues signals configured

* Imports bugs fixed (#45)

* Imports bugs fixed

* Comments resolved
@ruuushhh ruuushhh merged commit f7203ef into fyle_orgs_api Nov 30, 2023
1 check passed
ruuushhh added a commit that referenced this pull request Nov 30, 2023
* Get Fyle Orgs API

* Get user profile api (#34)

* Bug Fix: After testing (#35)

* Get user profile api

* Bug Fix: After testing

* Bug Fix: After testing

* Onboarding state bug fix

* Onboarding state bug fix

* Test case resolved

* Import expenses fixed

* Import expenses bug fixed

* test cases resolved

* test cases

* logic fixed for date

* Fix tests

* logic fixed for date

* Imports Folder Structure (#36)

* Imports Folder Structure

* Import base files added (#39)

* Import base files added

* Import Categories support added (#40)

* Import Categories support added

* Import merchants support added (#41)

* Import merchants support added

* Import cost centers support added (#42)

* Import cost centers support added

* Import project support added (#43)

* Import project support added

* Schedule, queues signals configured (#44)

* Schedule, queues signals configured

* Imports bugs fixed (#45)

* Imports bugs fixed

* Comments resolved
Copy link

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 2.296s ⏱️

ruuushhh added a commit that referenced this pull request Nov 30, 2023
* Import Business Central Attributes API added

* Business central fields api added

* Business central models added

* flake8 resolved

* models removed, commentrs resolved

* bug fixed

* Exportable expense groups api

* test cases added

* Expenses Sync APIs

* test cases resolved

* Expense sync APIs added

* Fyle orgs api (#33)

* Get Fyle Orgs API

* Get user profile api (#34)

* Bug Fix: After testing (#35)

* Get user profile api

* Bug Fix: After testing

* Bug Fix: After testing

* Onboarding state bug fix

* Onboarding state bug fix

* Test case resolved

* Import expenses fixed

* Import expenses bug fixed

* test cases resolved

* test cases

* logic fixed for date

* Fix tests

* logic fixed for date

* Imports Folder Structure (#36)

* Imports Folder Structure

* Import base files added (#39)

* Import base files added

* Import Categories support added (#40)

* Import Categories support added

* Import merchants support added (#41)

* Import merchants support added

* Import cost centers support added (#42)

* Import cost centers support added

* Import project support added (#43)

* Import project support added

* Schedule, queues signals configured (#44)

* Schedule, queues signals configured

* Imports bugs fixed (#45)

* Imports bugs fixed

* Comments resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants