chore: bump accounting mapping version #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughThe pull request involves an update to the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hrishabh17
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
ruuushhh
approved these changes
Dec 16, 2024
Hrishabh17
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Hrishabh17
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
+325
to
+329
| def test_run_import_export_with_no_bc_creds(db): | ||
| workspace_id = 10 | ||
| response = run_import_export(workspace_id=workspace_id) | ||
|
|
||
| assert response is None |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enhance test coverage and setup
The test appears overly simplistic compared to other test functions in this file. Consider the following improvements:
- Add proper workspace setup using the existing fixtures (create_temp_workspace)
- Document why None is the expected behavior when BC credentials are missing
- Verify that BusinessCentralCredentials are indeed not present
- Add assertions to confirm the workspace state remains unchanged
Here's a suggested implementation:
-def test_run_import_export_with_no_bc_creds(db):
- workspace_id = 10
- response = run_import_export(workspace_id=workspace_id)
-
- assert response is None
+def test_run_import_export_with_no_bc_creds(
+ db,
+ create_temp_workspace,
+ add_fyle_credentials,
+ create_export_settings
+):
+ """
+ Test run_import_export when Business Central credentials are missing.
+ Expected: Function should return None without processing any exports.
+ """
+ workspace_id = 1
+
+ # Verify BC credentials don't exist
+ assert not BusinessCentralCredentials.objects.filter(workspace_id=workspace_id).exists()
+
+ # Get initial state
+ initial_export_count = AccountingExport.objects.filter(workspace_id=workspace_id).count()
+
+ response = run_import_export(workspace_id=workspace_id)
+
+ # Verify response and no changes
+ assert response is None
+ assert AccountingExport.objects.filter(workspace_id=workspace_id).count() == initial_export_countCommittable suggestion skipped: line range outside the PR's diff.
Hrishabh17
had a problem deploying
to
CI Environment
GitHub Actions
Failure
|
Hrishabh17
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Hrishabh17
added a commit
that referenced
this pull request
Dec 19, 2024
* chore: bump accounting mapping version * Add testg * fix flaky test * fix flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump accounting mapping version
Clickup
https://app.clickup.com
Summary by CodeRabbit
fyle-accounting-mappingspackage to 1.35.0.