Fix: journal entry amounts #157

ruuushhh · 2024-07-30T11:05:21Z

Summary by CodeRabbit

New Features
- Updated calculations for journal entry amounts to enhance accuracy in financial reporting.
- Implemented logic changes to differentiate between total expenses and line item amounts, affecting how debits and credits are recorded.
Bug Fixes
- Corrected assertions in test cases to reflect the updated logic for journal entry amounts.
Chores
- Updated Docker command syntax in CI/CD workflows for improved compatibility with newer Docker versions.

coderabbitai · 2024-07-30T11:05:28Z

Walkthrough

The changes refine the accounting logic within the JournalEntry model by adjusting the calculation of amounts. The total expenses are now computed positively, enhancing clarity, while line item amounts are negated to maintain correct representation in journal entries. This ensures improved accuracy in financial reporting and aligns the logic with standard accounting practices.

Changes

Files	Change Summary
`apps/business_central/.../models.py`	Updated `create_or_update_object` method: expenses are summed positively, while line items are explicitly negated.
`tests/test_business_central/.../test_models.py`	Adjusted test assertions for `amount` from `-50` to `50`, and streamlined import statements.
`.github/workflows/.../codecov.yml`	Changed `docker-compose` to `docker compose` for improved command syntax in CI/CD workflow.
`.github/workflows/.../tests.yml`	Updated syntax from `docker-compose` to `docker compose` for consistency in CI workflow.

Poem

🐇 In the ledger where numbers play,
A twist in the tale, a bright new day!
Expenses now shine, no more in disguise,
While line items leap with a wink in their eyes.
Hooray for the changes, let’s dance and rejoice,
In the world of accounts, we’ll hop with a voice! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-07-30T11:06:54Z

Tests	Skipped	Failures	Errors	Time
122	0 💤	4 ❌	0 🔥	8.739s ⏱️

github-actions · 2024-07-30T11:06:58Z

Tests	Skipped	Failures	Errors	Time
122	0 💤	4 ❌	0 🔥	8.970s ⏱️

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0d9598e and f55c287.

Files selected for processing (1)

apps/business_central/exports/journal_entry/models.py (2 hunks)

Additional comments not posted (2)

apps/business_central/exports/journal_entry/models.py (2)

57-57: Verify the correctness of the amount calculation.

The calculation of the amount field has been changed from sum([expense.amount for expense in expenses]) * -1 to sum([expense.amount for expense in expenses]). This change alters the representation of debits and credits in journal entries. Ensure that this change aligns with the intended accounting logic.

122-122: Verify the correctness of the line item amount calculation.

The calculation of the amount field has been changed to lineitem.amount * -1. This change enforces a negative representation for line items. Ensure that this change aligns with the intended accounting logic.

github-actions · 2024-07-30T11:08:06Z

Tests	Skipped	Failures	Errors	Time
122	0 💤	4 ❌	0 🔥	9.051s ⏱️

github-actions · 2024-07-30T11:14:52Z

Tests	Skipped	Failures	Errors	Time
122	0 💤	0 ❌	0 🔥	8.976s ⏱️

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f55c287 and 7475c44.

Files selected for processing (1)

tests/test_business_central/test_models.py (5 hunks)

Additional comments not posted (5)

tests/test_business_central/test_models.py (5)

33-33: Verify the correctness of the updated assertion value.

The expected value for journal_entry.amount has been changed from -50 to 50. Ensure this change aligns with the updated business logic for journal entries.

69-69: Verify the correctness of the updated assertion value.

The expected value for journal_entry.amount has been changed from -50 to 50. Ensure this change aligns with the updated business logic for journal entries.

109-109: Verify the correctness of the updated assertion value.

The expected value for journal_entry.amount has been changed from -50 to 50. Ensure this change aligns with the updated business logic for journal entries.

144-144: Verify the correctness of the updated assertion value.

The expected value for journal_line_items[0].journal_entry.amount has been changed from -50 to 50. Ensure this change aligns with the updated business logic for journal entries.

Line range hint 162-162:
Verify the correctness of the updated assertion value.

The expected value for purchase_invoice.amount has been changed from -50 to 50. Ensure this change aligns with the updated business logic for purchase invoices.

github-actions · 2024-08-14T12:16:00Z

Tests	Skipped	Failures	Errors	Time
122	0 💤	0 ❌	0 🔥	9.258s ⏱️

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7475c44 and aa4829e.

Files selected for processing (2)

.github/workflows/codecov.yml (1 hunks)
.github/workflows/tests.yml (1 hunks)

Files skipped from review due to trivial changes (2)

.github/workflows/codecov.yml
.github/workflows/tests.yml

Fix: journal entry amounts

f55c287

ruuushhh self-assigned this Jul 30, 2024

ruuushhh had a problem deploying to CI Environment July 30, 2024 11:05 — with GitHub Actions Failure

ruuushhh added the deploy deploy to staging environment label Jul 30, 2024

ruuushhh temporarily deployed to Staging July 30, 2024 11:06 — with GitHub Actions Inactive

ruuushhh had a problem deploying to CI Environment July 30, 2024 11:06 — with GitHub Actions Failure

coderabbitai bot reviewed Jul 30, 2024

View reviewed changes

fix tests

7475c44

ruuushhh temporarily deployed to CI Environment July 30, 2024 11:13 — with GitHub Actions Inactive

coderabbitai bot reviewed Jul 30, 2024

View reviewed changes

Merge branch 'master' into fix-je-amount

d57ec41

ruuushhh had a problem deploying to CI Environment August 14, 2024 12:12 — with GitHub Actions Failure

Hrishabh17 approved these changes Aug 14, 2024

View reviewed changes

Fix test run

aa4829e

ruuushhh temporarily deployed to CI Environment August 14, 2024 12:14 — with GitHub Actions Inactive

coderabbitai bot reviewed Aug 14, 2024

View reviewed changes

ruuushhh merged commit ed5bcdb into master Aug 14, 2024
1 check passed

coderabbitai bot mentioned this pull request Nov 20, 2024

Feat: Adding new Journal Entry changes #175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: journal entry amounts #157

Fix: journal entry amounts #157

ruuushhh commented Jul 30, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 30, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

coderabbitai bot left a comment

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

coderabbitai bot left a comment

github-actions bot commented Aug 14, 2024

coderabbitai bot left a comment

Fix: journal entry amounts #157

Fix: journal entry amounts #157

Conversation

ruuushhh commented Jul 30, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jul 30, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 14, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

ruuushhh commented Jul 30, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)